The patch titled
Subject: include/linux/compiler-clang.h: handle randomizable anonymous structs
has been added to the -mm tree. Its filename is
compiler-clang-handle-randomizable-anonymous-structs.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/compiler-clang-handle-randomizable-anonymous-structs.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/compiler-clang-handle-randomizable-anonymous-structs.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Sandipan Das <sandipan@xxxxxxxxxxxxxxxxxx>
Subject: include/linux/compiler-clang.h: handle randomizable anonymous structs
The GCC randomize layout plugin can randomize the member offsets of
sensitive kernel data structures. To use this feature, certain
annotations and members are added to the structures which affect the
member offsets even if this plugin is not used.
All of these structures are completely randomized, except for task_struct
which leaves out some of its members. All the other members are wrapped
within an anonymous struct with the __randomize_layout attribute. This is
done using the randomized_struct_fields_start and
randomized_struct_fields_end defines. When the plugin is disabled, the
behaviour of this attribute can vary based on the GCC version. For GCC
5.1+, this attribute maps to __designated_init otherwise it is just an
empty define but the anonymous structure is still present. For other
compilers, both randomized_struct_fields_start and
randomized_struct_fields_end default to empty defines meaning the
anonymous structure is not introduced at all. So, if a module compiled
with Clang, such as a BPF program, needs to access task_struct fields such
as pid and comm, the offsets of these members as recognized by Clang are
different from those recognized by modules compiled with GCC. If GCC 4.6+
is used to build the kernel, this can be solved by introducing appropriate
defines for Clang so that the anonymous structure is seen when determining
the offsets for the members.
Link: http://lkml.kernel.org/r/20171109064645.25581-1-sandipan@xxxxxxxxxxxxxxxxxx
Signed-off-by: Sandipan Das <sandipan@xxxxxxxxxxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
Cc: Alexei Starovoitov <ast@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/compiler-clang.h | 3 +++
1 file changed, 3 insertions(+)
diff -puN include/linux/compiler-clang.h~compiler-clang-handle-randomizable-anonymous-structs include/linux/compiler-clang.h
--- a/include/linux/compiler-clang.h~compiler-clang-handle-randomizable-anonymous-structs
+++ a/include/linux/compiler-clang.h
@@ -16,3 +16,6 @@
* with any version that can compile the kernel
*/
#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
+
+#define randomized_struct_fields_start struct {
+#define randomized_struct_fields_end };
_
Patches currently in -mm which might be from sandipan@xxxxxxxxxxxxxxxxxx are
compiler-clang-handle-randomizable-anonymous-structs.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
