The patch titled
Subject: proc: use do-while in name_to_int()
has been added to the -mm tree. Its filename is
proc-use-do-while-in-name_to_int.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/proc-use-do-while-in-name_to_int.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/proc-use-do-while-in-name_to_int.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Subject: proc: use do-while in name_to_int()
Gcc doesn't know that "len" is guaranteed to be >=1 by dcache and
generates standard while-loop prologue duplicating loop condition.
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-27 (-27)
function old new delta
name_to_int 104 77 -27
Link: http://lkml.kernel.org/r/20170912195213.GB17730@avx2
Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/proc/util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/proc/util.c~proc-use-do-while-in-name_to_int fs/proc/util.c
--- a/fs/proc/util.c~proc-use-do-while-in-name_to_int
+++ a/fs/proc/util.c
@@ -8,7 +8,7 @@ unsigned name_to_int(const struct qstr *
if (len > 1 && *name == '0')
goto out;
- while (len-- > 0) {
+ do {
unsigned c = *name++ - '0';
if (c > 9)
goto out;
@@ -16,7 +16,7 @@ unsigned name_to_int(const struct qstr *
goto out;
n *= 10;
n += c;
- }
+ } while (--len > 0);
return n;
out:
return ~0U;
_
Patches currently in -mm which might be from adobriyan@xxxxxxxxx are
proc-uninline-name_to_int.patch
proc-use-do-while-in-name_to_int.patch
seq_file-delete-small-value-optimization.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
