From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Subject: test_kmod: remove paranoid UINT_MAX check on uint range processing The UINT_MAX comparison is not needed because "max" is already an unsigned int, and we expect developer C code max value input to have a sensible 0 - UINT_MAX range. Note that if it so happens to be UINT_MAX + 1 it would lead to an issue, but we expect the developer to know this. [mcgrof@xxxxxxxxxx: massaged commit log] Link: http://lkml.kernel.org/r/20170802211707.28020-2-mcgrof@xxxxxxxxxx Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Cc: Kees Cook <keescook@xxxxxxxxxxxx> Cc: Jessica Yu <jeyu@xxxxxxxxxx> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx> Cc: Michal Marek <mmarek@xxxxxxxx> Cc: Petr Mladek <pmladek@xxxxxxxx> Cc: Miroslav Benes <mbenes@xxxxxxx> Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> Cc: Shuah Khan <shuah@xxxxxxxxxx> Cc: Colin Ian King <colin.king@xxxxxxxxxxxxx> Cc: David Binderman <dcb314@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- lib/test_kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN lib/test_kmod.c~test_kmod-remove-paranoid-uint_max-check-on-uint-range-processing lib/test_kmod.c --- a/lib/test_kmod.c~test_kmod-remove-paranoid-uint_max-check-on-uint-range-processing +++ a/lib/test_kmod.c @@ -924,7 +924,7 @@ static int test_dev_config_update_uint_r if (ret) return ret; - if (new < min || new > max || new > UINT_MAX) + if (new < min || new > max) return -EINVAL; mutex_lock(&test_dev->config_mutex); _ -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
