Re: [patch 08/16] fortify: use WARN instead of BUG for now

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Aug 2017 16:40:44 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Aug 2, 2017 at 1:32 PM,  <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > From: Kees Cook <keescook@xxxxxxxxxxxx>
> > Subject: fortify: use WARN instead of BUG for now
> >
> > While CONFIG_FORTIFY_SOURCE continues to shake out, don't unconditionally
> > use BUG(), opting instead for WARN().  This also renames fortify_panic()
> > to fortify_overflow() which better matches what it is being called for.
> 
> This does not build for me. I get:
> 
>    In file included from ./include/linux/bitmap.h:8:0,
>                  from ./include/linux/cpumask.h:11,
>                  from ./arch/x86/include/asm/cpumask.h:4,
>                  from ./arch/x86/include/asm/msr.h:10,
>                  from ./arch/x86/include/asm/processor.h:20,
>                  from ./arch/x86/include/asm/cpufeature.h:4,
>                  from ./arch/x86/include/asm/thread_info.h:52,
>                  from ./include/linux/thread_info.h:37,
>                  from ./arch/x86/include/asm/preempt.h:6,
>                  from ./include/linux/preempt.h:80,
>                  from ./include/linux/spinlock.h:50,
>                  from ./include/linux/wait.h:8,
>                  from ./include/linux/wait_bit.h:7,
>                  from ./include/linux/fs.h:5,
>                  from ./include/linux/buffer_head.h:11,
>                  from fs/adfs/dir_f.c:12:
>    In function ___memcpy___,
>        inlined from _____adfs_dir_put___ at fs/adfs/dir_f.c:318:2,
>        inlined from ___adfs_f_update___ at fs/adfs/dir_f.c:403:2:
>    ./include/linux/string.h:305:4: error: call to _____read_overflow2___
> declared with attribute error: detected read beyond size of object
> passed as 2nd parameter
>        __read_overflow2();

oops.  I have an adfs fix.  Let me send...
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux