The patch titled
Subject: drivers/nvdimm/btt.c: remove btt_rw_page()
has been added to the -mm tree. Its filename is
btt-remove-btt_rw_page.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/btt-remove-btt_rw_page.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/btt-remove-btt_rw_page.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Subject: drivers/nvdimm/btt.c: remove btt_rw_page()
Patch series "remove rw_page() from brd, pmem and btt".
Dan Williams and Christoph Hellwig have recently expressed doubt about
whether the rw_page() interface made sense for synchronous memory drivers
[1][2]. It's unclear whether this interface has any performance benefit
for these drivers, but as we continue to fix bugs it is clear that it does
have a maintenance burden. This series removes the rw_page()
implementations in brd, pmem and btt to relieve this burden.
These patches have passed ext4 and XFS xfstest regression testing with
a memory mode pmem driver (without DAX), with pmem + btt and with brd.
This patch (of 3):
The rw_page() interface doesn't provide a clear performance benefit for
the BTT and has had a nonzero maintenance burden, so remove it.
Link: http://lkml.kernel.org/r/20170728165604.10455-2-ross.zwisler@xxxxxxxxxxxxxxx
Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Cc: "karam . lee" <karam.lee@xxxxxxx>
Cc: Minchan Kim <minchan@xxxxxxxxxx>
Cc: Jerome Marchand <jmarchan@xxxxxxxxxx>
Cc: Nitin Gupta <ngupta@xxxxxxxxxx>
Cc: Seungho Park <seungho1.park@xxxxxxx>
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxxxx>
Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/nvdimm/btt.c | 17 -----------------
1 file changed, 17 deletions(-)
diff -puN drivers/nvdimm/btt.c~btt-remove-btt_rw_page drivers/nvdimm/btt.c
--- a/drivers/nvdimm/btt.c~btt-remove-btt_rw_page
+++ a/drivers/nvdimm/btt.c
@@ -1236,22 +1236,6 @@ static blk_qc_t btt_make_request(struct
return BLK_QC_T_NONE;
}
-static int btt_rw_page(struct block_device *bdev, sector_t sector,
- struct page *page, bool is_write)
-{
- struct btt *btt = bdev->bd_disk->private_data;
- int rc;
- unsigned int len;
-
- len = hpage_nr_pages(page) * PAGE_SIZE;
- rc = btt_do_bvec(btt, NULL, page, len, 0, is_write, sector);
- if (rc == 0)
- page_endio(page, is_write, 0);
-
- return rc;
-}
-
-
static int btt_getgeo(struct block_device *bd, struct hd_geometry *geo)
{
/* some standard values */
@@ -1263,7 +1247,6 @@ static int btt_getgeo(struct block_devic
static const struct block_device_operations btt_fops = {
.owner = THIS_MODULE,
- .rw_page = btt_rw_page,
.getgeo = btt_getgeo,
.revalidate_disk = nvdimm_revalidate_disk,
};
_
Patches currently in -mm which might be from ross.zwisler@xxxxxxxxxxxxxxx are
mm-add-vm_insert_mixed_mkwrite.patch
dax-relocate-some-dax-functions.patch
dax-use-common-4k-zero-page-for-dax-mmap-reads.patch
dax-remove-dax-code-from-page_cache_tree_insert.patch
dax-move-all-dax-radix-tree-defs-to-fs-daxc.patch
btt-remove-btt_rw_page.patch
pmem-remove-pmem_rw_page.patch
brd-remove-brd_rw_page.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
