The patch titled
Subject: lib/test_bitmap.c: add optimisation tests
has been added to the -mm tree. Its filename is
test_bitmap-add-optimisation-tests.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/test_bitmap-add-optimisation-tests.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/test_bitmap-add-optimisation-tests.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
Subject: lib/test_bitmap.c: add optimisation tests
Patch series "Bitmap optimisations", v2.
These three bitmap patches use more efficient specialisations when the
compiler can figure out that it's safe to do so. Thanks to Rasmus's eagle
eyes, a nasty bug in v1 was avoided, and I've added a test case which
would have caught it.
This patch (of 4):
This version of the test is actually a no-op; the next patch will
enable it.
Link: http://lkml.kernel.org/r/20170628153221.11322-2-willy@xxxxxxxxxxxxx
Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/test_bitmap.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff -puN lib/test_bitmap.c~test_bitmap-add-optimisation-tests lib/test_bitmap.c
--- a/lib/test_bitmap.c~test_bitmap-add-optimisation-tests
+++ a/lib/test_bitmap.c
@@ -333,10 +333,42 @@ static void __init test_bitmap_u32_array
}
}
+#define __bitmap_set(a, b, c) bitmap_set(a, b, c)
+#define __bitmap_clear(a, b, c) bitmap_clear(a, b, c)
+
+static void noinline __init test_mem_optimisations(void)
+{
+ DECLARE_BITMAP(bmap1, 1024);
+ DECLARE_BITMAP(bmap2, 1024);
+ unsigned int start, nbits;
+
+ for (start = 0; start < 1024; start += 8) {
+ memset(bmap1, 0x5a, sizeof(bmap1));
+ memset(bmap2, 0x5a, sizeof(bmap2));
+ for (nbits = 0; nbits < 1024 - start; nbits += 8) {
+ bitmap_set(bmap1, start, nbits);
+ __bitmap_set(bmap2, start, nbits);
+ if (!bitmap_equal(bmap1, bmap2, 1024))
+ printk("set not equal %d %d\n", start, nbits);
+ if (!__bitmap_equal(bmap1, bmap2, 1024))
+ printk("set not __equal %d %d\n", start, nbits);
+
+ bitmap_clear(bmap1, start, nbits);
+ __bitmap_clear(bmap2, start, nbits);
+ if (!bitmap_equal(bmap1, bmap2, 1024))
+ printk("clear not equal %d %d\n", start, nbits);
+ if (!__bitmap_equal(bmap1, bmap2, 1024))
+ printk("clear not __equal %d %d\n", start,
+ nbits);
+ }
+ }
+}
+
static int __init test_bitmap_init(void)
{
test_zero_fill_copy();
test_bitmap_u32_array_conversions();
+ test_mem_optimisations();
if (failed_tests == 0)
pr_info("all %u tests passed\n", total_tests);
_
Patches currently in -mm which might be from mawilcox@xxxxxxxxxxxxx are
test_bitmap-add-optimisation-tests.patch
bitmap-optimise-bitmap_set-and-bitmap_clear-of-a-single-bit.patch
turn-bitmap_set-and-bitmap_clear-into-memset-when-possible.patch
bitmap-use-memcmp-optimisation-in-more-situations.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
