The patch titled
Subject: sendfile: do not update file offset of non-lseek()able objects.
has been added to the -mm tree. Its filename is
sendfile-do-not-update-file-offset-of-non-lseekable-objects.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/sendfile-do-not-update-file-offset-of-non-lseekable-objects.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/sendfile-do-not-update-file-offset-of-non-lseekable-objects.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: sendfile: do not update file offset of non-lseek()able objects.
I tried to sendfile() a file which is larger than 4GB to a pipe (which is
the stdout of Apache's CGI program), and noticed that sendfile() fails
with EFBIG after 2GB is copied to stdout pipe. This is because sendfile()
is updating file offset of the file descriptor of the pipe.
sendfile() should not update file offset if the file descriptor refers to
an non-lseek()able object.
Link: http://lkml.kernel.org/r/1497262469-7536-1-git-send-email-penguin-kernel@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/read_write.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/read_write.c~sendfile-do-not-update-file-offset-of-non-lseekable-objects fs/read_write.c
--- a/fs/read_write.c~sendfile-do-not-update-file-offset-of-non-lseekable-objects
+++ a/fs/read_write.c
@@ -1459,7 +1459,8 @@ static ssize_t do_sendfile(int out_fd, i
add_wchar(current, retval);
fsnotify_access(in.file);
fsnotify_modify(out.file);
- out.file->f_pos = out_pos;
+ if (out.file->f_op->llseek != no_llseek)
+ out.file->f_pos = out_pos;
if (ppos)
*ppos = pos;
else
_
Patches currently in -mm which might be from penguin-kernel@xxxxxxxxxxxxxxxxxxx are
sendfile-do-not-update-file-offset-of-non-lseekable-objects.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
