From: Cong Wang <xiyou.wangcong@xxxxxxxxx> Subject: 9p: fix a potential acl leak posix_acl_update_mode() could possibly clear 'acl', if so we leak the memory pointed by 'acl'. Save this pointer before calling posix_acl_update_mode() and release the memory if 'acl' really gets cleared. Link: http://lkml.kernel.org/r/1486678332-2430-1-git-send-email-xiyou.wangcong@xxxxxxxxx Signed-off-by: Cong Wang <xiyou.wangcong@xxxxxxxxx> Reported-by: Mark Salyzyn <salyzyn@xxxxxxxxxxx> Reviewed-by: Jan Kara <jack@xxxxxxx> Reviewed-by: Greg Kurz <groug@xxxxxxxx> Cc: Eric Van Hensbergen <ericvh@xxxxxxxxx> Cc: Ron Minnich <rminnich@xxxxxxxxxx> Cc: Latchesar Ionkov <lucho@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/9p/acl.c | 2 ++ 1 file changed, 2 insertions(+) diff -puN fs/9p/acl.c~9p-fix-a-potential-acl-leak fs/9p/acl.c --- a/fs/9p/acl.c~9p-fix-a-potential-acl-leak +++ a/fs/9p/acl.c @@ -277,6 +277,7 @@ static int v9fs_xattr_set_acl(const stru case ACL_TYPE_ACCESS: if (acl) { struct iattr iattr; + struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl); if (retval) @@ -287,6 +288,7 @@ static int v9fs_xattr_set_acl(const stru * by the mode bits. So don't * update ACL. */ + posix_acl_release(old_acl); value = NULL; size = 0; } _ -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
