The patch titled
Subject: lib/test_sort.c: make it explicitly non-modular
has been added to the -mm tree. Its filename is
lib-test_sort-make-it-explicitly-non-modular.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-test_sort-make-it-explicitly-non-modular.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-test_sort-make-it-explicitly-non-modular.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Subject: lib/test_sort.c: make it explicitly non-modular
The Kconfig currently controlling compilation of this code is:
lib/Kconfig.debug:config TEST_SORT
lib/Kconfig.debug: bool "Array-based sort test"
...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modular infrastructure use, so that
when reading the code there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering becomes slightly earlier when we change it
to use subsys_initcall as done here. However, since it is a self
contained test, this shouldn't be an issue and subsys_initcall
seems like a better fit for this particular case.
We also delete the MODULE_LICENSE tag since that information is now
contained at the top of the file in the comments.
Link: http://lkml.kernel.org/r/20170124225608.7319-1-paul.gortmaker@xxxxxxxxxxxxx
Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Cc: Kostenzer Felix <fkostenzer@xxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/test_sort.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff -puN lib/test_sort.c~lib-test_sort-make-it-explicitly-non-modular lib/test_sort.c
--- a/lib/test_sort.c~lib-test_sort-make-it-explicitly-non-modular
+++ a/lib/test_sort.c
@@ -1,8 +1,11 @@
#include <linux/sort.h>
#include <linux/slab.h>
-#include <linux/module.h>
+#include <linux/init.h>
-/* a simple boot-time regression test */
+/*
+ * A simple boot-time regression test
+ * License: GPL
+ */
#define TEST_LEN 1000
@@ -38,6 +41,4 @@ exit:
kfree(a);
return err;
}
-
-module_init(test_sort_init);
-MODULE_LICENSE("GPL");
+subsys_initcall(test_sort_init);
_
Patches currently in -mm which might be from paul.gortmaker@xxxxxxxxxxxxx are
lib-test_sort-make-it-explicitly-non-modular.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
