The patch titled
Subject: lib: add CONFIG_TEST_SORT to enable self-test of sort()
has been added to the -mm tree. Its filename is
lib-add-config_test_sort-to-enable-self-test-of-sort.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-add-config_test_sort-to-enable-self-test-of-sort.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-add-config_test_sort-to-enable-self-test-of-sort.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Kostenzer Felix <fkostenzer@xxxxxxx>
Subject: lib: add CONFIG_TEST_SORT to enable self-test of sort()
Along with the addition made to Kconfig.debug, the prior existing but
permanently disabled test function has been slightly refactored.
Patch has been tested using QEMU 2.1.2 with a .config obtained through
'make defconfig' (x86_64) and manually enabling the option.
Link: http://lkml.kernel.org/r/HE1PR09MB0394B0418D504DCD27167D4FD49B0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Kostenzer Felix <fkostenzer@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/Kconfig.debug | 8 ++++++++
lib/sort.c | 41 ++++++++++++++++++++++++-----------------
2 files changed, 32 insertions(+), 17 deletions(-)
diff -puN lib/Kconfig.debug~lib-add-config_test_sort-to-enable-self-test-of-sort lib/Kconfig.debug
--- a/lib/Kconfig.debug~lib-add-config_test_sort-to-enable-self-test-of-sort
+++ a/lib/Kconfig.debug
@@ -1714,6 +1714,14 @@ config TEST_LIST_SORT
If unsure, say N.
+config TEST_SORT
+ bool "Array-based sort test"
+ depends on DEBUG_KERNEL
+ help
+ This option enables the self-test function of 'sort()' at boot.
+
+ If unsure, say N.
+
config KPROBES_SANITY_TEST
bool "Kprobes sanity tests"
depends on DEBUG_KERNEL
diff -puN lib/sort.c~lib-add-config_test_sort-to-enable-self-test-of-sort lib/sort.c
--- a/lib/sort.c~lib-add-config_test_sort-to-enable-self-test-of-sort
+++ a/lib/sort.c
@@ -4,6 +4,8 @@
* Jan 23 2005 Matt Mackall <mpm@xxxxxxxxxxx>
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/types.h>
#include <linux/export.h>
#include <linux/sort.h>
@@ -102,41 +104,46 @@ void sort(void *base, size_t num, size_t
EXPORT_SYMBOL(sort);
-#if 0
+#ifdef CONFIG_TEST_SORT
#include <linux/slab.h>
+#include <linux/module.h>
/* a simple boot-time regression test */
-int cmpint(const void *a, const void *b)
+#define TEST_LEN 1000
+
+static int __init cmpint(const void *a, const void *b)
{
return *(int *)a - *(int *)b;
}
-static int sort_test(void)
+static int __init test_sort_init(void)
{
- int *a, i, r = 1;
-
- a = kmalloc(1000 * sizeof(int), GFP_KERNEL);
- BUG_ON(!a);
+ int *a, i, r = 1, err = -ENOMEM;
- printk("testing sort()\n");
+ a = kmalloc_array(TEST_LEN, sizeof(*a), GFP_KERNEL);
+ if (!a)
+ return err;
- for (i = 0; i < 1000; i++) {
+ for (i = 0; i < TEST_LEN; i++) {
r = (r * 725861) % 6599;
a[i] = r;
}
- sort(a, 1000, sizeof(int), cmpint, NULL);
+ sort(a, TEST_LEN, sizeof(*a), cmpint, NULL);
- for (i = 0; i < 999; i++)
+ err = -EINVAL;
+ for (i = 0; i < TEST_LEN-1; i++)
if (a[i] > a[i+1]) {
- printk("sort() failed!\n");
- break;
+ pr_err("test has failed\n");
+ goto exit;
}
-
+ err = 0;
+ pr_info("test passed\n");
+exit:
kfree(a);
-
- return 0;
+ return err;
}
-module_init(sort_test);
+module_init(test_sort_init);
+MODULE_LICENSE("GPL");
#endif
_
Patches currently in -mm which might be from fkostenzer@xxxxxxx are
lib-add-config_test_sort-to-enable-self-test-of-sort.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
