The patch titled
Subject: mm, page_alloc: fix incorrect zone_statistics data
has been added to the -mm tree. Its filename is
mm-page_alloc-fix-incorrect-zone_statistics-data.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-page_alloc-fix-incorrect-zone_statistics-data.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-page_alloc-fix-incorrect-zone_statistics-data.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jia He <hejianet@xxxxxxxxx>
Subject: mm, page_alloc: fix incorrect zone_statistics data
In commit b9f00e147f27 ("mm, page_alloc: reduce branches in
zone_statistics"), it reconstructed codes to reduce the branch miss rate.
Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE)
z->node would not be equal to preferred_zone->node. That seems to be
incorrect.
Fixes: commit b9f00e147f27 ("mm, page_alloc: reduce branches in
zone_statistics")
Link: http://lkml.kernel.org/r/1481522347-20393-2-git-send-email-hejianet@xxxxxxxxx
Signed-off-by: Jia He <hejianet@xxxxxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: Taku Izumi <izumi.taku@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/page_alloc.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN mm/page_alloc.c~mm-page_alloc-fix-incorrect-zone_statistics-data mm/page_alloc.c
--- a/mm/page_alloc.c~mm-page_alloc-fix-incorrect-zone_statistics-data
+++ a/mm/page_alloc.c
@@ -2603,6 +2603,9 @@ static inline void zone_statistics(struc
if (z->node == local_nid) {
__inc_zone_state(z, NUMA_HIT);
__inc_zone_state(z, local_stat);
+ } else if (z->node == preferred_zone->node) {
+ __inc_zone_state(z, NUMA_HIT);
+ __inc_zone_state(z, NUMA_OTHER);
} else {
__inc_zone_state(z, NUMA_MISS);
__inc_zone_state(preferred_zone, NUMA_FOREIGN);
_
Patches currently in -mm which might be from hejianet@xxxxxxxxx are
mm-page_alloc-fix-incorrect-zone_statistics-data.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
