The patch titled
Subject: mm/filemap.c: fix a NULL dereference crash while accessing bdev->bd_disk
has been removed from the -mm tree. Its filename was
mm-fix-a-null-dereference-crash-while-accessing-bdev-bd_disk.patch
This patch was dropped because it had testing failures
------------------------------------------------------
From: Wei Fang <fangwei1@xxxxxxxxxx>
Subject: mm/filemap.c: fix a NULL dereference crash while accessing bdev->bd_disk
->bd_disk is assigned to NULL in __blkdev_put() when no one is holding the
bdev. After that, ->bd_inode still can be touched in the
blockdev_superblock->s_inodes list before the final iput. So
iterate_bdevs() can still get this inode, and start writeback on mapping
dirty pages. ->bd_disk will be dereferenced in
mapping_cap_writeback_dirty() in this case, and a NULL dereference crash
will be triggered:
Unable to handle kernel NULL pointer dereference at virtual address 00000388
...
[<ffff8000004cb1e4>] blk_get_backing_dev_info+0x1c/0x28
[<ffff8000001c879c>] __filemap_fdatawrite_range+0x54/0x98
[<ffff8000001c8804>] filemap_fdatawrite+0x24/0x2c
[<ffff80000027e7a4>] fdatawrite_one_bdev+0x20/0x28
[<ffff800000288b44>] iterate_bdevs+0xec/0x144
[<ffff80000027eb50>] sys_sync+0x84/0xd0
Since mapping_cap_writeback_dirty() is always return true about block
device inodes, no need to check it if the inode is a block device inode.
Link: http://lkml.kernel.org/r/1480125982-8497-1-git-send-email-fangwei1@xxxxxxxxxx
Signed-off-by: Wei Fang <fangwei1@xxxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/filemap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN mm/filemap.c~mm-fix-a-null-dereference-crash-while-accessing-bdev-bd_disk mm/filemap.c
--- a/mm/filemap.c~mm-fix-a-null-dereference-crash-while-accessing-bdev-bd_disk
+++ a/mm/filemap.c
@@ -383,8 +383,9 @@ int __filemap_fdatawrite_range(struct ad
.range_end = end,
};
- if (!mapping_cap_writeback_dirty(mapping))
- return 0;
+ if (!sb_is_blkdev_sb(mapping->host->i_sb))
+ if (!mapping_cap_writeback_dirty(mapping))
+ return 0;
wbc_attach_fdatawrite_inode(&wbc, mapping->host);
ret = do_writepages(mapping, &wbc);
_
Patches currently in -mm which might be from fangwei1@xxxxxxxxxx are
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
