The patch titled
Subject: ipc-sem-simplify-wait-wake-loop-checkpatch-fixes
has been added to the -mm tree. Its filename is
ipc-sem-simplify-wait-wake-loop-checkpatch-fixes.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/ipc-sem-simplify-wait-wake-loop-checkpatch-fixes.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/ipc-sem-simplify-wait-wake-loop-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: ipc-sem-simplify-wait-wake-loop-checkpatch-fixes
WARNING: line over 80 characters
#69: FILE: ipc/sem.c:1997:
+ * fastpath: the semop has completed, either successfully or not, from
WARNING: line over 80 characters
#70: FILE: ipc/sem.c:1998:
+ * the syscall pov, is quite irrelevant to us at this point; we're done.
WARNING: line over 80 characters
#73: FILE: ipc/sem.c:2001:
+ * spuriously. The queue.status is checked again in the slowpath (aka
WARNING: line over 80 characters
#74: FILE: ipc/sem.c:2002:
+ * after taking sem_lock), such that we can detect scenarios where we
WARNING: line over 80 characters
#75: FILE: ipc/sem.c:2003:
+ * were awakened externally, during the window between wake_q_add() and
WARNING: line over 80 characters
#84: FILE: ipc/sem.c:2009:
+ * User space could assume that semop() is a memory barrier:
WARNING: line over 80 characters
#85: FILE: ipc/sem.c:2010:
+ * Without the mb(), the cpu could speculatively read in user
WARNING: line over 80 characters
#86: FILE: ipc/sem.c:2011:
+ * space stale data that was overwritten by the previous owner
total: 0 errors, 8 warnings, 127 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/ipc-sem-simplify-wait-wake-loop.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Cc: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
ipc/sem.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff -puN ipc/sem.c~ipc-sem-simplify-wait-wake-loop-checkpatch-fixes ipc/sem.c
--- a/ipc/sem.c~ipc-sem-simplify-wait-wake-loop-checkpatch-fixes
+++ a/ipc/sem.c
@@ -1994,22 +1994,23 @@ SYSCALL_DEFINE4(semtimedop, int, semid,
schedule();
/*
- * fastpath: the semop has completed, either successfully or not, from
- * the syscall pov, is quite irrelevant to us at this point; we're done.
+ * fastpath: the semop has completed, either successfully or
+ * not, from the syscall pov, is quite irrelevant to us at this
+ * point; we're done.
*
* We _do_ care, nonetheless, about being awoken by a signal or
- * spuriously. The queue.status is checked again in the slowpath (aka
- * after taking sem_lock), such that we can detect scenarios where we
- * were awakened externally, during the window between wake_q_add() and
- * wake_up_q().
+ * spuriously. The queue.status is checked again in the
+ * slowpath (aka after taking sem_lock), such that we can detect
+ * scenarios where we were awakened externally, during the
+ * window between wake_q_add() and wake_up_q().
*/
error = READ_ONCE(queue.status);
if (error != -EINTR) {
/*
- * User space could assume that semop() is a memory barrier:
- * Without the mb(), the cpu could speculatively read in user
- * space stale data that was overwritten by the previous owner
- * of the semaphore.
+ * User space could assume that semop() is a memory
+ * barrier: Without the mb(), the cpu could
+ * speculatively read in userspace stale data that was
+ * overwritten by the previous owner of the semaphore.
*/
smp_mb();
goto out_free;
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
i-need-old-gcc.patch
arm-arch-arm-include-asm-pageh-needs-personalityh.patch
prctl-remove-one-shot-limitation-for-changing-exe-link-fix.patch
mm.patch
mm-compaction-allow-compaction-for-gfp_nofs-requests-fix.patch
mm-mempolicy-clean-up-__gfp_thisnode-confusion-in-policy_zonelist-checkpatch-fixes.patch
mm-unexport-__get_user_pages_unlocked-checkpatch-fixes.patch
scripts-checkpatchpl-fix-spelling.patch
debug-more-properly-delay-for-secondary-cpus-fix.patch
ipc-sem-rework-task-wakeups-checkpatch-fixes.patch
ipc-sem-optimize-perform_atomic_semop-checkpatch-fixes.patch
ipc-sem-simplify-wait-wake-loop-checkpatch-fixes.patch
drivers-net-wireless-intel-iwlwifi-dvm-calibc-fix-min-warning.patch
kernel-forkc-export-kernel_thread-to-modules.patch
slab-leaks3-default-y.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
