On Wed, 19 Oct 2016 10:07:46 +0200 Michal Hocko <mhocko@xxxxxxxxxx> wrote: > On Tue 18-10-16 13:34:34, Andrew Morton wrote: > > From: Aristeu Rozanski <arozansk@xxxxxxxxxx> > > Subject: ipc: account for kmem usage on mqueue and msg > > > > When kmem accounting switched from account by default to only account if > > flagged by __GFP_ACCOUNT, IPC mqueue and messages was left out. > > Andrew, could you please add the information about the usecase provided > by Stefan? > " > The production use case at hand is that mqueues should be customizable > via sysctls in Docker containers in a Kubernetes cluster. This can only > be safely allowed to the users of the cluster (without the risk that > they can cause resource shortage on a node, influencing other users' > containers) if all resources they control are bounded, i.e. accounted > for. > " From: Aristeu Rozanski <arozansk@xxxxxxxxxx> Subject: ipc: account for kmem usage on mqueue and msg When kmem accounting switched from account by default to only account if flagged by __GFP_ACCOUNT, IPC mqueue and messages was left out. The production use case at hand is that mqueues should be customizable via sysctls in Docker containers in a Kubernetes cluster. This can only be safely allowed to the users of the cluster (without the risk that they can cause resource shortage on a node, influencing other users' containers) if all resources they control are bounded, i.e. accounted for. Link: http://lkml.kernel.org/r/1476806075-1210-1-git-send-email-arozansk@xxxxxxxxxx Signed-off-by: Aristeu Rozanski <arozansk@xxxxxxxxxx> Reported-by: Stefan Schimanski <sttts@xxxxxxxxxx> Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx> Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxxxx> Cc: Vladimir Davydov <vdavydov.dev@xxxxxxxxx> Cc: Stefan Schimanski <sttts@xxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- ipc/msgutil.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN ipc/msgutil.c~ipc-account-for-kmem-usage-on-mqueue-and-msg ipc/msgutil.c --- a/ipc/msgutil.c~ipc-account-for-kmem-usage-on-mqueue-and-msg +++ a/ipc/msgutil.c @@ -53,7 +53,7 @@ static struct msg_msg *alloc_msg(size_t size_t alen; alen = min(len, DATALEN_MSG); - msg = kmalloc(sizeof(*msg) + alen, GFP_KERNEL); + msg = kmalloc(sizeof(*msg) + alen, GFP_KERNEL_ACCOUNT); if (msg == NULL) return NULL; @@ -65,7 +65,7 @@ static struct msg_msg *alloc_msg(size_t while (len > 0) { struct msg_msgseg *seg; alen = min(len, DATALEN_SEG); - seg = kmalloc(sizeof(*seg) + alen, GFP_KERNEL); + seg = kmalloc(sizeof(*seg) + alen, GFP_KERNEL_ACCOUNT); if (seg == NULL) goto out_err; *pseg = seg; _ -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
