The patch titled
Subject: mm/vmalloc.c: simplify /proc/vmallocinfo implementation
has been added to the -mm tree. Its filename is
mm-vmallocc-simplify-proc-vmallocinfo-implementation.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-vmallocc-simplify-proc-vmallocinfo-implementation.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-vmallocc-simplify-proc-vmallocinfo-implementation.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: zijun_hu <zijun_hu@xxxxxxx>
Subject: mm/vmalloc.c: simplify /proc/vmallocinfo implementation
Many seq_file helpers exist for simplifying implementation of virtual
files especially, for /proc nodes. however, the helpers for iteration
over list_head are available but aren't adopted to implement
/proc/vmallocinfo currently.
Simplify /proc/vmallocinfo implementation by using existing seq_file
helpers.
Link: http://lkml.kernel.org/r/57FDF2E5.1000201@xxxxxxxx
Signed-off-by: zijun_hu <zijun_hu@xxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Tejun Heo <tj@xxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmalloc.c | 27 +++++----------------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff -puN mm/vmalloc.c~mm-vmallocc-simplify-proc-vmallocinfo-implementation mm/vmalloc.c
--- a/mm/vmalloc.c~mm-vmallocc-simplify-proc-vmallocinfo-implementation
+++ a/mm/vmalloc.c
@@ -2540,32 +2540,13 @@ void pcpu_free_vm_areas(struct vm_struct
static void *s_start(struct seq_file *m, loff_t *pos)
__acquires(&vmap_area_lock)
{
- loff_t n = *pos;
- struct vmap_area *va;
-
spin_lock(&vmap_area_lock);
- va = list_first_entry(&vmap_area_list, typeof(*va), list);
- while (n > 0 && &va->list != &vmap_area_list) {
- n--;
- va = list_next_entry(va, list);
- }
- if (!n && &va->list != &vmap_area_list)
- return va;
-
- return NULL;
-
+ return seq_list_start(&vmap_area_list, *pos);
}
static void *s_next(struct seq_file *m, void *p, loff_t *pos)
{
- struct vmap_area *va = p, *next;
-
- ++*pos;
- next = list_next_entry(va, list);
- if (&next->list != &vmap_area_list)
- return next;
-
- return NULL;
+ return seq_list_next(p, &vmap_area_list, pos);
}
static void s_stop(struct seq_file *m, void *p)
@@ -2600,9 +2581,11 @@ static void show_numa_info(struct seq_fi
static int s_show(struct seq_file *m, void *p)
{
- struct vmap_area *va = p;
+ struct vmap_area *va;
struct vm_struct *v;
+ va = list_entry(p, struct vmap_area, list);
+
/*
* s_show can encounter race with remove_vm_area, !VM_VM_AREA on
* behalf of vmap area is being tear down or vm_map_ram allocation.
_
Patches currently in -mm which might be from zijun_hu@xxxxxxx are
mm-vmallocc-simplify-proc-vmallocinfo-implementation.patch
mm-percpuc-fix-panic-triggered-by-bug_on-falsely.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
