[merged] freezer-oom-check-tif_memdie-on-the-correct-task.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: freezer, oom: check TIF_MEMDIE on the correct task
has been removed from the -mm tree.  Its filename was
     freezer-oom-check-tif_memdie-on-the-correct-task.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Michal Hocko <mhocko@xxxxxxxx>
Subject: freezer, oom: check TIF_MEMDIE on the correct task

freezing_slow_path() is checking TIF_MEMDIE to skip OOM killed tasks.  It
is, however, checking the flag on the current task rather than the given
one.  This is really confusing because freezing() can be called also on
!current tasks.  It would end up working correctly for its main purpose
because __refrigerator will be always called on the current task so the
oom victim will never get frozen.  But it could lead to surprising results
when a task which is freezing a cgroup got oom killed because only part of
the cgroup would get frozen.  This is highly unlikely but worth fixing as
the resulting code would be more clear anyway.

Link: http://lkml.kernel.org/r/1467029719-17602-2-git-send-email-mhocko@xxxxxxxxxx
Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Miao Xie <miaox@xxxxxxxxxxxxxx>
Cc: Miao Xie <miaoxie@xxxxxxxxxx>
Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 kernel/freezer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/freezer.c~freezer-oom-check-tif_memdie-on-the-correct-task kernel/freezer.c
--- a/kernel/freezer.c~freezer-oom-check-tif_memdie-on-the-correct-task
+++ a/kernel/freezer.c
@@ -42,7 +42,7 @@ bool freezing_slow_path(struct task_stru
 	if (p->flags & (PF_NOFREEZE | PF_SUSPEND_TASK))
 		return false;
 
-	if (test_thread_flag(TIF_MEMDIE))
+	if (test_tsk_thread_flag(p, TIF_MEMDIE))
 		return false;
 
 	if (pm_nosig_freezing || cgroup_freezing(p))
_

Patches currently in -mm which might be from mhocko@xxxxxxxx are


--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]
  Powered by Linux