The patch titled Subject: fs/befs/linuxvfs.c: check silent flag before logging errors has been added to the -mm tree. Its filename is fs-befs-check-silent-flag-before-logging-errors.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/fs-befs-check-silent-flag-before-logging-errors.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/fs-befs-check-silent-flag-before-logging-errors.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Salah Triki <salah.triki@xxxxxxx> Subject: fs/befs/linuxvfs.c: check silent flag before logging errors Log errors only when silent flag is not set. Link: http://lkml.kernel.org/r/d400aaf5a7430de79bd956e40ec075fb1cb08474.1464226521.git.salah.triki@xxxxxxx Signed-off-by: Salah Triki <salah.triki@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/befs/linuxvfs.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff -puN fs/befs/linuxvfs.c~fs-befs-check-silent-flag-before-logging-errors fs/befs/linuxvfs.c --- a/fs/befs/linuxvfs.c~fs-befs-check-silent-flag-before-logging-errors +++ a/fs/befs/linuxvfs.c @@ -772,7 +772,8 @@ befs_fill_super(struct super_block *sb, befs_sb = BEFS_SB(sb); if (!parse_options((char *) data, &befs_sb->mount_opts)) { - befs_error(sb, "cannot parse mount options"); + if (!silent) + befs_error(sb, "cannot parse mount options"); goto unacquire_priv_sbp; } @@ -796,7 +797,8 @@ befs_fill_super(struct super_block *sb, sb_min_blocksize(sb, 1024); if (!(bh = sb_bread(sb, sb_block))) { - befs_error(sb, "unable to read superblock"); + if (!silent) + befs_error(sb, "unable to read superblock"); goto unacquire_priv_sbp; } @@ -820,9 +822,9 @@ befs_fill_super(struct super_block *sb, brelse(bh); if( befs_sb->num_blocks > ~((sector_t)0) ) { - befs_error(sb, "blocks count: %llu " - "is larger than the host can use", - befs_sb->num_blocks); + if (!silent) + befs_error(sb, "blocks count: %llu is larger than the host can use", + befs_sb->num_blocks); goto unacquire_priv_sbp; } @@ -841,7 +843,8 @@ befs_fill_super(struct super_block *sb, } sb->s_root = d_make_root(root); if (!sb->s_root) { - befs_error(sb, "get root inode failed"); + if (!silent) + befs_error(sb, "get root inode failed"); goto unacquire_priv_sbp; } _ Patches currently in -mm which might be from salah.triki@xxxxxxx are fs-befs-move-useless-assignment.patch fs-befs-check-silent-flag-before-logging-errors.patch fs-befs-remove-useless-pr_err.patch fs-befs-remove-useless-befs_error.patch fs-befs-remove-useless-pr_err-in-befs_init_inodecache.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html