The patch titled
Subject: mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes
has been added to the -mm tree. Its filename is
mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#10:
[1] http://lkml.kernel.org/r/20160519002809.GA10245@js1304-P5Q-DELUXE
WARNING: Missing a blank line after declarations
#34: FILE: include/linux/page_idle.h:50:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#45: FILE: include/linux/page_idle.h:60:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#57: FILE: include/linux/page_idle.h:70:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#68: FILE: include/linux/page_idle.h:80:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#79: FILE: include/linux/page_idle.h:90:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#90: FILE: include/linux/page_idle.h:100:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
total: 1 errors, 6 warnings, 196 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: Yang Shi <yang.shi@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/page_idle.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff -puN include/linux/page_idle.h~mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes include/linux/page_idle.h
--- a/include/linux/page_idle.h~mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes
+++ a/include/linux/page_idle.h
@@ -46,8 +46,8 @@ extern struct page_ext_operations page_i
static inline bool page_is_young(struct page *page)
{
- struct page_ext *page_ext;
- page_ext = lookup_page_ext(page);
+ struct page_ext *page_ext = lookup_page_ext(page);
+
if (unlikely(!page_ext)
return false;
@@ -56,8 +56,8 @@ static inline bool page_is_young(struct
static inline void set_page_young(struct page *page)
{
- struct page_ext *page_ext;
- page_ext = lookup_page_ext(page);
+ struct page_ext *page_ext = lookup_page_ext(page);
+
if (unlikely(!page_ext)
return;
@@ -66,8 +66,8 @@ static inline void set_page_young(struct
static inline bool test_and_clear_page_young(struct page *page)
{
- struct page_ext *page_ext;
- page_ext = lookup_page_ext(page);
+ struct page_ext *page_ext = lookup_page_ext(page);
+
if (unlikely(!page_ext)
return false;
@@ -76,8 +76,8 @@ static inline bool test_and_clear_page_y
static inline bool page_is_idle(struct page *page)
{
- struct page_ext *page_ext;
- page_ext = lookup_page_ext(page);
+ struct page_ext *page_ext = lookup_page_ext(page);
+
if (unlikely(!page_ext)
return false;
@@ -86,8 +86,8 @@ static inline bool page_is_idle(struct p
static inline void set_page_idle(struct page *page)
{
- struct page_ext *page_ext;
- page_ext = lookup_page_ext(page);
+ struct page_ext *page_ext = lookup_page_ext(page);
+
if (unlikely(!page_ext)
return;
@@ -96,8 +96,8 @@ static inline void set_page_idle(struct
static inline void clear_page_idle(struct page *page)
{
- struct page_ext *page_ext;
- page_ext = lookup_page_ext(page);
+ struct page_ext *page_ext = lookup_page_ext(page);
+
if (unlikely(!page_ext)
return;
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
i-need-old-gcc.patch
arch-alpha-kernel-systblss-remove-debug-check.patch
arm-arch-arm-include-asm-pageh-needs-personalityh.patch
mm.patch
mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes.patch
mm-thp-avoid-unnecessary-swapin-in-khugepaged-fix.patch
allocate-idle-task-for-a-cpu-always-on-its-local-node-fix.patch
drivers-net-wireless-intel-iwlwifi-dvm-calibc-fix-min-warning.patch
kernel-forkc-export-kernel_thread-to-modules.patch
slab-leaks3-default-y.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
