The patch titled Subject: radix-tree: fix sibling entry insertion has been removed from the -mm tree. Its filename was radix-tree-fix-sibling-entry-insertion.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> Subject: radix-tree: fix sibling entry insertion The subtraction was the wrong way round, leading to undefined behaviour (shift by an amount larger than the size of the type). Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx> Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> Cc: Konstantin Khlebnikov <koct9i@xxxxxxxxx> Cc: Kirill Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> Cc: Jan Kara <jack@xxxxxxxx> Cc: Neil Brown <neilb@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- lib/radix-tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN lib/radix-tree.c~radix-tree-fix-sibling-entry-insertion lib/radix-tree.c --- a/lib/radix-tree.c~radix-tree-fix-sibling-entry-insertion +++ a/lib/radix-tree.c @@ -526,8 +526,8 @@ int __radix_tree_create(struct radix_tre #ifdef CONFIG_RADIX_TREE_MULTIORDER /* Insert pointers to the canonical entry */ - if ((shift - order) > 0) { - int i, n = 1 << (shift - order); + if (order > shift) { + int i, n = 1 << (order - shift); offset = offset & ~(n - 1); slot = ptr_to_indirect(&node->slots[offset]); for (i = 0; i < n; i++) { _ Patches currently in -mm which might be from willy@xxxxxxxxxxxxxxx are radix-tree-fix-deleting-a-multi-order-entry-through-an-alias.patch radix-tree-remove-restriction-on-multi-order-entries.patch radix-tree-introduce-radix_tree_load_root.patch radix-tree-fix-extending-the-tree-for-multi-order-entries-at-offset-0.patch radix-tree-test-suite-start-adding-multiorder-tests.patch radix-tree-fix-several-shrinking-bugs-with-multiorder-entries.patch radix-tree-rewrite-__radix_tree_lookup.patch radix-tree-fix-multiorder-bug_on-in-radix_tree_insert.patch radix-tree-fix-radix_tree_create-for-sibling-entries.patch radix-tree-rewrite-radix_tree_locate_item.patch radix-tree-fix-radix_tree_range_tag_if_tagged-for-multiorder-entries.patch radix-tree-add-copyright-statements.patch drivers-hwspinlock-use-correct-radix-tree-api.patch radix-tree-miscellaneous-fixes.patch radix-tree-split-node-path-into-offset-and-height.patch radix-tree-replace-node-height-with-node-shift.patch radix-tree-remove-a-use-of-root-height-from-delete_node.patch radix-tree-test-suite-remove-dependencies-on-height.patch radix-tree-remove-root-height.patch radix-tree-rename-indirect_ptr-to-internal_node.patch radix-tree-rename-ptr_to_indirect-to-node_to_entry.patch radix-tree-rename-indirect_to_ptr-to-entry_to_node.patch radix-tree-rename-radix_tree_is_indirect_ptr.patch radix-tree-change-naming-conventions-in-radix_tree_shrink.patch radix-tree-tidy-up-next_chunk.patch radix-tree-tidy-up-range_tag_if_tagged.patch radix-tree-tidy-up-__radix_tree_create.patch radix-tree-introduce-radix_tree_replace_clear_tags.patch radix-tree-make-radix_tree_descend-more-useful.patch radix-tree-free-up-the-bottom-bit-of-exceptional-entries-for-reuse.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html