The patch titled atm/ambassador: fix return code bug has been added to the -mm tree. Its filename is atm-ambassador-fix-return-code-bug.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: atm/ambassador: fix return code bug From: Jeff Garzik <jeff@xxxxxxxxxx> While auditing a 'may be used uninitialized' warning, I found a minor bug: make_rate() has the standard error code convention -- zero for success, negative errno on error -- but its return type is defined as unsigned. Change the return type to reflect reality. Signed-off-by: Jeff Garzik <jeff@xxxxxxxxxx> Cc: Chas Williams <chas@xxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/atm/ambassador.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/atm/ambassador.c~atm-ambassador-fix-return-code-bug drivers/atm/ambassador.c --- a/drivers/atm/ambassador.c~atm-ambassador-fix-return-code-bug +++ a/drivers/atm/ambassador.c @@ -915,8 +915,8 @@ static irqreturn_t interrupt_handler(int /********** make rate (not quite as much fun as Horizon) **********/ -static unsigned int make_rate (unsigned int rate, rounding r, - u16 * bits, unsigned int * actual) { +static int make_rate (unsigned int rate, rounding r, + u16 * bits, unsigned int * actual) { unsigned char exp = -1; // hush gcc unsigned int man = -1; // hush gcc _ Patches currently in -mm which might be from jeff@xxxxxxxxxx are origin.patch acpi-fix-64-bit-pointer-truncation-bugs.patch git-libata-all.patch libata-return-sense-data-in-hdio_drive_cmd-ioctl.patch libata-return-sense-data-in-hdio_drive_cmd-ioctl-tidy.patch via-pata-controller-xfer-fixes.patch ahci-ati-sb600-sata-support-for-various-modes.patch git-netdev-all.patch update-smc91x-driver-with-arm-versatile-board-info.patch b44-fix-eeprom-endianess-issue.patch forcedeth-hardirq-lockdep-warning.patch forcedeth-power-management-support.patch forcedeth-power-management-support-tidy.patch remove-unnecessary-check-in-drivers-net-depcac.patch 8139too-force-media-setting-fix.patch tulip-fix-shutdown-dma-irq-race.patch zatm-always-clear-pcr-in-alloc_shaper.patch atm-ambassador-fix-return-code-bug.patch r8169-driver-corega-support-patch.patch git-pciseg.patch usb-serial-mos7840-fix-cast.patch fs-eventpoll-error-handling-micro-cleanup.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html