The patch titled
Subject: vdso: make arch_setup_additional_pages wait for mmap_sem for write killable
has been added to the -mm tree. Its filename is
vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Michal Hocko <mhocko@xxxxxxxx>
Subject: vdso: make arch_setup_additional_pages wait for mmap_sem for write killable
most architectures are relying on mmap_sem for write in their
arch_setup_additional_pages. If the waiting task gets killed by the oom
killer it would block oom_reaper from asynchronous address space reclaim
and reduce the chances of timely OOM resolving. Wait for the lock in the
killable mode and return with EINTR if the task got killed while waiting.
Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
Acked-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx> [x86 vdso]
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
arch/arm/kernel/process.c | 3 ++-
arch/arm64/kernel/vdso.c | 6 ++++--
arch/hexagon/kernel/vdso.c | 3 ++-
arch/mips/kernel/vdso.c | 3 ++-
arch/powerpc/kernel/vdso.c | 3 ++-
arch/s390/kernel/vdso.c | 3 ++-
arch/sh/kernel/vsyscall/vsyscall.c | 4 +++-
arch/x86/entry/vdso/vma.c | 3 ++-
arch/x86/um/vdso/vma.c | 3 ++-
9 files changed, 21 insertions(+), 10 deletions(-)
diff -puN arch/arm/kernel/process.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/arm/kernel/process.c
--- a/arch/arm/kernel/process.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/arm/kernel/process.c
@@ -420,7 +420,8 @@ int arch_setup_additional_pages(struct l
npages = 1; /* for sigpage */
npages += vdso_total_pages;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
hint = sigpage_addr(mm, npages);
addr = get_unmapped_area(NULL, hint, npages << PAGE_SHIFT, 0, 0);
if (IS_ERR_VALUE(addr)) {
diff -puN arch/arm64/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/arm64/kernel/vdso.c
--- a/arch/arm64/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/arm64/kernel/vdso.c
@@ -95,7 +95,8 @@ int aarch32_setup_vectors_page(struct li
};
void *ret;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
current->mm->context.vdso = (void *)addr;
/* Map vectors page at the high address. */
@@ -163,7 +164,8 @@ int arch_setup_additional_pages(struct l
/* Be sure to map the data page */
vdso_mapping_len = vdso_text_len + PAGE_SIZE;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
vdso_base = get_unmapped_area(NULL, 0, vdso_mapping_len, 0, 0);
if (IS_ERR_VALUE(vdso_base)) {
ret = ERR_PTR(vdso_base);
diff -puN arch/hexagon/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/hexagon/kernel/vdso.c
--- a/arch/hexagon/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/hexagon/kernel/vdso.c
@@ -65,7 +65,8 @@ int arch_setup_additional_pages(struct l
unsigned long vdso_base;
struct mm_struct *mm = current->mm;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
/* Try to get it loaded right near ld.so/glibc. */
vdso_base = STACK_TOP;
diff -puN arch/mips/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/mips/kernel/vdso.c
--- a/arch/mips/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/mips/kernel/vdso.c
@@ -104,7 +104,8 @@ int arch_setup_additional_pages(struct l
struct resource gic_res;
int ret;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
/*
* Determine total area size. This includes the VDSO data itself, the
diff -puN arch/powerpc/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/powerpc/kernel/vdso.c
--- a/arch/powerpc/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/powerpc/kernel/vdso.c
@@ -195,7 +195,8 @@ int arch_setup_additional_pages(struct l
* and end up putting it elsewhere.
* Add enough to the size so that the result can be aligned.
*/
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
vdso_base = get_unmapped_area(NULL, vdso_base,
(vdso_pages << PAGE_SHIFT) +
((VDSO_ALIGNMENT - 1) & PAGE_MASK),
diff -puN arch/s390/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/s390/kernel/vdso.c
--- a/arch/s390/kernel/vdso.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/s390/kernel/vdso.c
@@ -216,7 +216,8 @@ int arch_setup_additional_pages(struct l
* it at vdso_base which is the "natural" base for it, but we might
* fail and end up putting it elsewhere.
*/
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
vdso_base = get_unmapped_area(NULL, 0, vdso_pages << PAGE_SHIFT, 0, 0);
if (IS_ERR_VALUE(vdso_base)) {
rc = vdso_base;
diff -puN arch/sh/kernel/vsyscall/vsyscall.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/sh/kernel/vsyscall/vsyscall.c
--- a/arch/sh/kernel/vsyscall/vsyscall.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/sh/kernel/vsyscall/vsyscall.c
@@ -64,7 +64,9 @@ int arch_setup_additional_pages(struct l
unsigned long addr;
int ret;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
+
addr = get_unmapped_area(NULL, 0, PAGE_SIZE, 0, 0);
if (IS_ERR_VALUE(addr)) {
ret = addr;
diff -puN arch/x86/entry/vdso/vma.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/x86/entry/vdso/vma.c
--- a/arch/x86/entry/vdso/vma.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/x86/entry/vdso/vma.c
@@ -163,7 +163,8 @@ static int map_vdso(const struct vdso_im
addr = 0;
}
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
addr = get_unmapped_area(NULL, addr,
image->size - image->sym_vvar_start, 0, 0);
diff -puN arch/x86/um/vdso/vma.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable arch/x86/um/vdso/vma.c
--- a/arch/x86/um/vdso/vma.c~vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable
+++ a/arch/x86/um/vdso/vma.c
@@ -61,7 +61,8 @@ int arch_setup_additional_pages(struct l
if (!vdso_enabled)
return 0;
- down_write(&mm->mmap_sem);
+ if (down_write_killable(&mm->mmap_sem))
+ return -EINTR;
err = install_special_mapping(mm, um_vdso_addr, PAGE_SIZE,
VM_READ|VM_EXEC|
_
Patches currently in -mm which might be from mhocko@xxxxxxxx are
include-linux-nodemaskh-create-next_node_in-helper-fix.patch
mm-oom-move-gfp_nofs-check-to-out_of_memory.patch
oom-oom_reaper-try-to-reap-tasks-which-skip-regular-oom-killer-path.patch
oom-oom_reaper-try-to-reap-tasks-which-skip-regular-oom-killer-path-try-to-reap-tasks-which-skip-regular-memcg-oom-killer-path.patch
mm-oom_reaper-clear-tif_memdie-for-all-tasks-queued-for-oom_reaper.patch
mm-oom_reaper-clear-tif_memdie-for-all-tasks-queued-for-oom_reaper-clear-oom_reaper_list-before-clearing-tif_memdie.patch
vmscan-consider-classzone_idx-in-compaction_ready.patch
mm-compaction-change-compact_-constants-into-enum.patch
mm-compaction-cover-all-compaction-mode-in-compact_zone.patch
mm-compaction-distinguish-compact_deferred-from-compact_skipped.patch
mm-compaction-distinguish-between-full-and-partial-compact_complete.patch
mm-compaction-update-compaction_result-ordering.patch
mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface.patch
mm-compaction-abstract-compaction-feedback-to-helpers.patch
mm-use-compaction-feedback-for-thp-backoff-conditions.patch
mm-oom-rework-oom-detection.patch
mm-throttle-on-io-only-when-there-are-too-many-dirty-and-writeback-pages.patch
mm-oom-protect-costly-allocations-some-more.patch
mm-consider-compaction-feedback-also-for-costly-allocation.patch
mm-oom-compaction-prevent-from-should_compact_retry-looping-for-ever-for-costly-orders.patch
mm-oom_reaper-hide-oom-reaped-tasks-from-oom-killer-more-carefully.patch
mm-oom_reaper-do-not-mmput-synchronously-from-the-oom-reaper-context.patch
mm-oom_reaper-do-not-mmput-synchronously-from-the-oom-reaper-context-fix.patch
mm-make-mmap_sem-for-write-waits-killable-for-mm-syscalls.patch
mm-make-vm_mmap-killable.patch
mm-make-vm_munmap-killable.patch
mm-aout-handle-vm_brk-failures.patch
mm-elf-handle-vm_brk-error.patch
mm-make-vm_brk-killable.patch
mm-proc-make-clear_refs-killable.patch
mm-fork-make-dup_mmap-wait-for-mmap_sem-for-write-killable.patch
ipc-shm-make-shmem-attach-detach-wait-for-mmap_sem-killable.patch
vdso-make-arch_setup_additional_pages-wait-for-mmap_sem-for-write-killable.patch
coredump-make-coredump_wait-wait-for-mmap_sem-for-write-killable.patch
aio-make-aio_setup_ring-killable.patch
exec-make-exec-path-waiting-for-mmap_sem-killable.patch
prctl-make-pr_set_thp_disable-wait-for-mmap_sem-killable.patch
uprobes-wait-for-mmap_sem-for-write-killable.patch
drm-i915-make-i915_gem_mmap_ioctl-wait-for-mmap_sem-killable.patch
drm-radeon-make-radeon_mn_get-wait-for-mmap_sem-killable.patch
drm-amdgpu-make-amdgpu_mn_get-wait-for-mmap_sem-killable.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
