The patch titled Subject: mm/highmem: simplify is_highmem() has been added to the -mm tree. Its filename is mm-highmem-simplify-is_highmem.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-highmem-simplify-is_highmem.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-highmem-simplify-is_highmem.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Chanho Min <chanho.min@xxxxxxx> Subject: mm/highmem: simplify is_highmem() is_highmem() can be simplified by use of is_highmem_idx(). This patch removes redundant code and will make it easier to maintain if the zone policy is changed or a new zone is added. (akpm: saves me 25 bytes of text per is_highmem() callsite) Signed-off-by: Chanho Min <chanho.min@xxxxxxx> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/mmzone.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff -puN include/linux/mmzone.h~mm-highmem-simplify-is_highmem include/linux/mmzone.h --- a/include/linux/mmzone.h~mm-highmem-simplify-is_highmem +++ a/include/linux/mmzone.h @@ -828,10 +828,7 @@ static inline int is_highmem_idx(enum zo static inline int is_highmem(struct zone *zone) { #ifdef CONFIG_HIGHMEM - int zone_off = (char *)zone - (char *)zone->zone_pgdat->node_zones; - return zone_off == ZONE_HIGHMEM * sizeof(*zone) || - (zone_off == ZONE_MOVABLE * sizeof(*zone) && - zone_movable_is_highmem()); + return is_highmem_idx(zone_idx(zone)); #else return 0; #endif _ Patches currently in -mm which might be from chanho.min@xxxxxxx are mm-highmem-simplify-is_highmem.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html