The patch titled
Subject: checkpatch: warn on bare unsigned or signed declarations without int
has been added to the -mm tree. Its filename is
checkpatch-warn-on-bare-unsigned-or-signed-declarations-without-int.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-warn-on-bare-unsigned-or-signed-declarations-without-int.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-warn-on-bare-unsigned-or-signed-declarations-without-int.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joe Perches <joe@xxxxxxxxxxx>
Subject: checkpatch: warn on bare unsigned or signed declarations without int
Kernel style prefers "unsigned int <foo>" over "unsigned <foo>" and
"signed int <foo>" over "signed <foo>".
Emit a warning for these simple signed/unsigned <foo> declarations.
Fix it too if desired.
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-warn-on-bare-unsigned-or-signed-declarations-without-int scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-warn-on-bare-unsigned-or-signed-declarations-without-int
+++ a/scripts/checkpatch.pl
@@ -3239,6 +3239,26 @@ sub process {
#ignore lines not being added
next if ($line =~ /^[^\+]/);
+# check for declarations of signed or unsigned without int
+ while ($line =~ m{($Declare++)\s*($Ident)\s*[=,;\[\)]}g) {
+ my $type = $1;
+ my $var = $2;
+ if ($type =~ /^((?:un)?signed)((?:\s*\*)*)\s*$/) {
+ my $sign = $1;
+ my $pointer = $2;
+
+ $pointer = "" if (!defined $pointer);
+
+ if (WARN("UNSPECIFIED_INT",
+ "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) &&
+ $fix) {
+ my $decl = trim($sign) . " int ";
+ $decl .= trim($pointer) if (rtrim($pointer) ne "");
+ $fixed[$fixlinenr] =~ s@\b\Q$type\E\s*$var\b@$decl$var@;
+ }
+ }
+ }
+
# TEST: allow direct testing of the type matcher.
if ($dbg_type) {
if ($line =~ /^.\s*$Declare\s*$/) {
_
Patches currently in -mm which might be from joe@xxxxxxxxxxx are
mm-convert-pr_warning-to-pr_warn.patch
mm-coalesce-split-strings.patch
mm-convert-printkkern_level-to-pr_level.patch
mm-percpu-use-pr_fmt-to-prefix-output.patch
checkpatch-exclude-asm-volatile-from-complex-macro-check.patch
checkpatch-warn-on-bare-unsigned-or-signed-declarations-without-int.patch
kernel-convert-pr_warning-to-pr_warn.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
