+ mm-hugetlb-hugetlb_no_page-rate-limit-warning-message.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: mm/hugetlb: hugetlb_no_page: Rate-limit warning message
has been added to the -mm tree.  Its filename is
     mm-hugetlb-hugetlb_no_page-rate-limit-warning-message.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-hugetlb_no_page-rate-limit-warning-message.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-hugetlb_no_page-rate-limit-warning-message.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Geoffrey Thomas <geofft@xxxxxxxxxxxxx>
Subject: mm/hugetlb: hugetlb_no_page: Rate-limit warning message

The warning message "killed due to inadequate hugepage pool" simply
indicates that SIGBUS was sent, not that the process was forcibly killed. 
If the process has a signal handler installed does not fix the problem,
this message can rapidly spam the kernel log.

On my amd64 dev machine that does not have hugepages configured, I can
reproduce the repeated warnings easily by setting vm.nr_hugepages=2 (i.e.,
4 megabytes of huge pages) and running something that sets a signal
handler and forks, like

#include <sys/mman.h>
#include <signal.h>
#include <stdlib.h>
#include <unistd.h>

sig_atomic_t counter = 10;
void handler(int signal) {
 	if (counter-- == 0)
 		exit(0);
}

int main(void) {
 	int status;
 	char *addr = mmap(NULL, 4 * 1048576, PROT_READ | PROT_WRITE,
 			  MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB, -1, 0);
 	if (addr == MAP_FAILED) {perror("mmap"); return 1;}
 	*addr = 'x';
 	switch (fork()) {
 		case -1:
 			perror("fork"); return 1;
 		case 0:
 			signal(SIGBUS, handler);
 			*addr = 'x';
 			break;
 		default:
 			*addr = 'x';
 			wait(&status);
 			if (WIFSIGNALED(status)) {
 				psignal(WTERMSIG(status), "child");
 			}
 			break;
 	}
}

Signed-off-by: Geoffrey Thomas <geofft@xxxxxxxxxxxxx>
Cc: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
Cc: Hillf Danton <hillf.zj@xxxxxxxxxxxxxxx>
Cc: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 mm/hugetlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/hugetlb.c~mm-hugetlb-hugetlb_no_page-rate-limit-warning-message mm/hugetlb.c
--- a/mm/hugetlb.c~mm-hugetlb-hugetlb_no_page-rate-limit-warning-message
+++ a/mm/hugetlb.c
@@ -3502,7 +3502,7 @@ static int hugetlb_no_page(struct mm_str
 	 * COW. Warn that such a situation has occurred as it may not be obvious
 	 */
 	if (is_vma_resv_set(vma, HPAGE_RESV_UNMAPPED)) {
-		pr_warning("PID %d killed due to inadequate hugepage pool\n",
+		pr_warn_ratelimited("PID %d killed due to inadequate hugepage pool\n",
 			   current->pid);
 		return ret;
 	}
_

Patches currently in -mm which might be from geofft@xxxxxxxxxxxxx are

mm-hugetlb-hugetlb_no_page-rate-limit-warning-message.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux