The patch titled
Subject: mm: vmscan: do not clear SHRINKER_NUMA_AWARE if nr_node_ids == 1
has been added to the -mm tree. Its filename is
mm-vmscan-do-not-clear-shrinker_numa_aware-if-nr_node_ids-==-1.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-vmscan-do-not-clear-shrinker_numa_aware-if-nr_node_ids-%3D%3D-1.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-vmscan-do-not-clear-shrinker_numa_aware-if-nr_node_ids-%3D%3D-1.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Subject: mm: vmscan: do not clear SHRINKER_NUMA_AWARE if nr_node_ids == 1
Currently, on shrinker registration we clear SHRINKER_NUMA_AWARE if
there's the only NUMA node present. The comment states that this will
allow us to save some small loop time later. It used to be true when this
code was added (see commit 1d3d4437eae1b ("vmscan: per-node deferred
work")), but since commit 6b4f7799c6a57 ("mm: vmscan: invoke slab
shrinkers from shrink_zone()") it doesn't make any difference. Anyway,
running on non-NUMA machine shouldn't make a shrinker NUMA unaware, so zap
this hunk.
Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>
Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmscan.c | 8 --------
1 file changed, 8 deletions(-)
diff -puN mm/vmscan.c~mm-vmscan-do-not-clear-shrinker_numa_aware-if-nr_node_ids-==-1 mm/vmscan.c
--- a/mm/vmscan.c~mm-vmscan-do-not-clear-shrinker_numa_aware-if-nr_node_ids-==-1
+++ a/mm/vmscan.c
@@ -228,14 +228,6 @@ int register_shrinker(struct shrinker *s
{
size_t size = sizeof(*shrinker->nr_deferred);
- /*
- * If we only have one possible node in the system anyway, save
- * ourselves the trouble and disable NUMA aware behavior. This way we
- * will save memory and some small loop time later.
- */
- if (nr_node_ids == 1)
- shrinker->flags &= ~SHRINKER_NUMA_AWARE;
-
if (shrinker->flags & SHRINKER_NUMA_AWARE)
size *= nr_node_ids;
_
Patches currently in -mm which might be from vdavydov@xxxxxxxxxxxxx are
vmpressure-fix-subtree-pressure-detection.patch
mm-vmscan-do-not-clear-shrinker_numa_aware-if-nr_node_ids-==-1.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
