The patch titled Subject: reiserfs: fix dereference of ERR_PTR has been added to the -mm tree. Its filename is reiserfs-fix-dereference-of-err_ptr.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/reiserfs-fix-dereference-of-err_ptr.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/reiserfs-fix-dereference-of-err_ptr.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> Subject: reiserfs: fix dereference of ERR_PTR reiserfs_iget() returns either NULL or error code in ERR_PTR. And we were only checking for NULL, so in case of some other error we will try to dereference the ERR_PTR(-errno) thinking it to be a valid pointer. Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/reiserfs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/reiserfs/super.c~reiserfs-fix-dereference-of-err_ptr fs/reiserfs/super.c --- a/fs/reiserfs/super.c~reiserfs-fix-dereference-of-err_ptr +++ a/fs/reiserfs/super.c @@ -288,7 +288,7 @@ static int finish_unfinished(struct supe pathrelse(&path); inode = reiserfs_iget(s, &obj_key); - if (!inode) { + if (IS_ERR_OR_NULL(inode)) { /* * the unlink almost completed, it just did not * manage to remove "save" link and release objectid _ Patches currently in -mm which might be from sudipm.mukherjee@xxxxxxxxx are reiserfs-fix-dereference-of-err_ptr.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html