On Mon, 28 Dec 2015 18:29:31 -0500 Sasha Levin <sasha.levin@xxxxxxxxxx> wrote: > On 12/28/2015 06:19 PM, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > The patch titled > > Subject: thp: fix regression in handling mlocked pages in __split_huge_pmd() > > has been added to the -mm tree. Its filename is > > mm-dax-dax-pmd-vs-thp-pmd-vs-hugetlbfs-pmd-fix.patch > > > > This patch should soon appear at > > http://ozlabs.org/~akpm/mmots/broken-out/mm-dax-dax-pmd-vs-thp-pmd-vs-hugetlbfs-pmd-fix.patch > > and later at > > http://ozlabs.org/~akpm/mmotm/broken-out/mm-dax-dax-pmd-vs-thp-pmd-vs-hugetlbfs-pmd-fix.patch > > > > Before you just go and hit "reply", please: > > a) Consider who else should be cc'ed > > b) Prefer to cc a suitable mailing list as well > > c) Ideally: find the original patch on the mailing list and do a > > reply-to-all to that, adding suitable additional cc's > > > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > > > The -mm tree is included into linux-next and is updated > > there every 3-4 working days > > > > ------------------------------------------------------ > > From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> > > Subject: thp: fix regression in handling mlocked pages in __split_huge_pmd() > > > > This patch fixes regression caused by patch > > "mm, dax: dax-pmd vs thp-pmd vs hugetlbfs-pmd" > > > > The patch makes pmd_trans_huge() check and "page = pmd_page(*pmd)" after > > __split_huge_pmd_locked(). It can never succeed, since the pmd already > > points to a page table. As result the page is never get munlocked. > > > > It causes crashes like this: > > http://lkml.kernel.org/r/5661FBB6.6050307@xxxxxxxxxx > > I've mentioned it in the original threat, but this patch doesn't fix the > issue I've reported. Yes, thanks, noted. This is a really big problem - I'm sitting on a HUGE number of MM and DAX patches and I don't know which ones will need to be held out of 4.5 if we can't get this fixed, and holding out some patches will screw up everything else. So please, guys - urgency on this one! > Maybe it fixes a different issue, but the description > should be different. Yup, I deleted the third paragraph. -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
