The patch titled
Subject: lib/clz_tab.c: put in lib-y rather than obj-y
has been added to the -mm tree. Its filename is
lib-clz_tabc-put-in-lib-y-rather-than-obj-y.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-clz_tabc-put-in-lib-y-rather-than-obj-y.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-clz_tabc-put-in-lib-y-rather-than-obj-y.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Chris Metcalf <cmetcalf@xxxxxxxxxx>
Subject: lib/clz_tab.c: put in lib-y rather than obj-y
The clz table (__clz_tab) in lib/clz_tab.c is also provided as part of
libgcc.a, and many architectures link against libgcc. To allow the linker
to avoid a multiple-definition link failure, clz_tab.o has to be in
lib/lib.a rather than lib/builtin.o. The specific issue is that libgcc.a
comes before lib/builtin.o on vmlinux.o's link command line, so its _clz.o
is pulled to satisfy __clz_tab, and then when the remainder of
lib/builtin.o is pulled in to satisfy all the other dependencies, the
__clz_tab symbols conflict. By putting clz_tab.o in lib.a, the linker can
simply avoid pulling it into vmlinux.o when this situation arises.
The definitions of __clz_tab are the same in libgcc.a and in the kernel;
arguably we could also simply rename the kernel version, but it's unlikely
the libgcc version will ever change to become incompatible, so just using
it seems reasonably safe.
Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>
Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN lib/Makefile~lib-clz_tabc-put-in-lib-y-rather-than-obj-y lib/Makefile
--- a/lib/Makefile~lib-clz_tabc-put-in-lib-y-rather-than-obj-y
+++ a/lib/Makefile
@@ -153,7 +153,7 @@ obj-$(CONFIG_GLOB) += glob.o
obj-$(CONFIG_MPILIB) += mpi/
obj-$(CONFIG_SIGNATURE) += digsig.o
-obj-$(CONFIG_CLZ_TAB) += clz_tab.o
+lib-$(CONFIG_CLZ_TAB) += clz_tab.o
obj-$(CONFIG_DDR) += jedec_ddr_data.o
_
Patches currently in -mm which might be from cmetcalf@xxxxxxxxxx are
lib-clz_tabc-put-in-lib-y-rather-than-obj-y.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
