The patch titled
Subject: vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix
has been added to the -mm tree. Its filename is
vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Christoph Lameter <cl@xxxxxxxxx>
Subject: vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix
Hmmm... We got a race condition since quiet_vmstat touches cpu_stat_off
which may not be allocated early in the bootup sequence. Causes oopses on
boot.
Subject: vmstat: quieting vmstat requires a running system
Do not do anything unless the system is actually running. Otherwise
we may crash on bootup.
Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmstat.c | 3 +++
1 file changed, 3 insertions(+)
diff -puN mm/vmstat.c~vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix mm/vmstat.c
--- a/mm/vmstat.c~vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix
+++ a/mm/vmstat.c
@@ -1416,6 +1416,9 @@ static void vmstat_update(struct work_st
*/
void quiet_vmstat(void)
{
+ if (system_state != SYSTEM_RUNNING)
+ return;
+
do {
if (!cpumask_test_and_set_cpu(smp_processor_id(), cpu_stat_off))
cancel_delayed_work(this_cpu_ptr(&vmstat_work));
_
Patches currently in -mm which might be from cl@xxxxxxxxx are
vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle.patch
vmstat-make-vmstat_updater-deferrable-again-and-shut-down-on-idle-fix.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
