The patch titled Subject: inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch-v2 has been removed from the -mm tree. Its filename was inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch-v2.patch This patch was dropped because it was folded into inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch.patch ------------------------------------------------------ From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Subject: inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch-v2 Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Cc: John McCutchan <john@xxxxxxxxxxxxxxxxx> Cc: Robert Love <rlove@xxxxxxxxx> Cc: Eric Paris <eparis@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/notify/inotify/inotify_user.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff -puN fs/notify/inotify/inotify_user.c~inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch-v2 fs/notify/inotify/inotify_user.c --- a/fs/notify/inotify/inotify_user.c~inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch-v2 +++ a/fs/notify/inotify/inotify_user.c @@ -706,10 +706,19 @@ SYSCALL_DEFINE3(inotify_add_watch, int, int ret; unsigned flags = 0; - /* don't allow invalid bits: we don't want flags set */ + /* + * We share a lot of code with fs/dnotify. We also share + * the bit layout between inotify's IN_* and the fsnotify + * FS_*. This check ensures that only the inotify IN_* + * bits get passed in and set in watches/events. + */ if (unlikely(mask & ~ALL_INOTIFY_BITS)) return -EINVAL; - /* require at least one valid bit set in the mask */ + /* + * Require at least one valid bit set in the mask. + * Without _something_ set, we would have no events to + * watch for. + */ if (unlikely(!(mask & ALL_INOTIFY_BITS))) return -EINVAL; _ Patches currently in -mm which might be from dave.hansen@xxxxxxxxxxxxxxx are inotify-hide-internal-kernel-bits-from-fdinfo.patch inotify-actually-check-for-invalid-bits-in-sys_inotify_add_watch.patch mm-hugetlb-use-memory-policy-when-available.patch mm-hugetlb-use-memory-policy-when-available-fix.patch mm-hugetlbfs-optimize-when-numa=n.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html