The patch titled Subject: signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix has been added to the -mm tree. Its filename is signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Oleg Nesterov <oleg@xxxxxxxxxx> Subject: signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix As Markus reports (thanks!) signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch conflicts with the recent change in Linus' tree, > I just realised that this patch will conflict with a fixup patch for nbd > that will be included in rc7. > > dcc909d90ccd (nbd: Add locking for tasks) > > I think there is basically one new instance of dequeue_signal_lock() that > needs to be replaced with kernel_dequeue_signal(). Unless I missed something, this new dequeue_signal_lock() should simply die, but lets fix the conflict first. Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx> Cc: Felipe Balbi <balbi@xxxxxx> Cc: Markus Pargmann <mpa@xxxxxxxxxxxxxx> Cc: Tejun Heo <tj@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/block/nbd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff -puN drivers/block/nbd.c~signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix drivers/block/nbd.c --- a/drivers/block/nbd.c~signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix +++ a/drivers/block/nbd.c @@ -587,10 +587,8 @@ static int nbd_thread_send(void *data) spin_unlock_irqrestore(&nbd->tasks_lock, flags); /* Clear maybe pending signals */ - if (signal_pending(current)) { - siginfo_t info; - dequeue_signal_lock(current, ¤t->blocked, &info); - } + if (signal_pending(current)) + kernel_dequeue_signal(NULL); return 0; } _ Patches currently in -mm which might be from oleg@xxxxxxxxxx are mmoom-fix-potentially-killing-unrelated-process-fix.patch mm-fix-the-racy-mm-locked_vm-change-in.patch mm-add-the-struct-mm_struct-mm-local-into.patch mm-oom_kill-remove-the-wrong-fatal_signal_pending-check-in-oom_kill_process.patch mm-oom_kill-cleanup-the-kill-sharing-same-memory-loop.patch mm-oom_kill-fix-the-wrong-task-mm-==-mm-checks-in-oom_kill_process.patch change-current_is_single_threaded-to-use-for_each_thread.patch signals-kill-block_all_signals-and-unblock_all_signals.patch signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal-fix.patch signal-introduce-kernel_signal_stop-to-fix-jffs2_garbage_collect_thread.patch signal-remove-jffs2_garbage_collect_thread-allow_signalsigcont.patch coredump-ensure-all-coredumping-tasks-have-signal_group_coredump.patch coredump-change-zap_threads-and-zap_process-to-use-for_each_thread.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html