The patch titled
Subject: mm/slub: calculate start order with reserved in consideration
has been added to the -mm tree. Its filename is
mm-slub-calculate-start-order-with-reserved-in-consideration.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-slub-calculate-start-order-with-reserved-in-consideration.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-calculate-start-order-with-reserved-in-consideration.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Wei Yang <weiyang@xxxxxxxxxxxxxxxxxx>
Subject: mm/slub: calculate start order with reserved in consideration
In slub_order(), the order starts from max(min_order,
get_order(min_objects * size)). When (min_objects * size) has different
order from (min_objects * size + reserved), it will skip this order via a
check in the loop.
This patch optimizes this a little by calculating the start order with
`reserved' in consideration and removing the check in loop.
Signed-off-by: Wei Yang <weiyang@xxxxxxxxxxxxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slub.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff -puN mm/slub.c~mm-slub-calculate-start-order-with-reserved-in-consideration mm/slub.c
--- a/mm/slub.c~mm-slub-calculate-start-order-with-reserved-in-consideration
+++ a/mm/slub.c
@@ -3022,19 +3022,15 @@ static inline int slab_order(int size, i
if (order_objects(min_order, size, reserved) > MAX_OBJS_PER_PAGE)
return get_order(size * MAX_OBJS_PER_PAGE) - 1;
- for (order = max(min_order, get_order(min_objects * size));
+ for (order = max(min_order, get_order(min_objects * size + reserved));
order <= max_order; order++) {
unsigned long slab_size = PAGE_SIZE << order;
- if (slab_size < min_objects * size + reserved)
- continue;
-
rem = (slab_size - reserved) % size;
if (rem <= slab_size / fract_leftover)
break;
-
}
return order;
_
Patches currently in -mm which might be from weiyang@xxxxxxxxxxxxxxxxxx are
mm-slub-correct-the-comment-in-calculate_order.patch
mm-slub-use-get_order-instead-of-fls.patch
mm-slub-calculate-start-order-with-reserved-in-consideration.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
