The patch titled Subject: fs/nfs/dir.c: remove unnecessary new_valid_dev() check has been added to the -mm tree. Its filename is fs-nfs-remove-unnecessary-new_valid_dev-check.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/fs-nfs-remove-unnecessary-new_valid_dev-check.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/fs-nfs-remove-unnecessary-new_valid_dev-check.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Yaowei Bai <bywxiaobai@xxxxxxx> Subject: fs/nfs/dir.c: remove unnecessary new_valid_dev() check new_valid_dev() always returns 1, so the !new_valid_dev() check is not needed. Remove it. Signed-off-by: Yaowei Bai <bywxiaobai@xxxxxxx> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> Cc: Anna Schumaker <anna.schumaker@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/nfs/dir.c | 3 --- 1 file changed, 3 deletions(-) diff -puN fs/nfs/dir.c~fs-nfs-remove-unnecessary-new_valid_dev-check fs/nfs/dir.c --- a/fs/nfs/dir.c~fs-nfs-remove-unnecessary-new_valid_dev-check +++ a/fs/nfs/dir.c @@ -1714,9 +1714,6 @@ nfs_mknod(struct inode *dir, struct dent dfprintk(VFS, "NFS: mknod(%s/%lu), %pd\n", dir->i_sb->s_id, dir->i_ino, dentry); - if (!new_valid_dev(rdev)) - return -EINVAL; - attr.ia_mode = mode; attr.ia_valid = ATTR_MODE; _ Patches currently in -mm which might be from bywxiaobai@xxxxxxx are kernel-watchdog-is_hardlockup-can-be-boolean.patch mm-page_alloc-remove-unused-parameter-in-init_currently_empty_zone.patch mm-vmscan-make-inactive_anon_is_low_global-return-directly.patch mm-oom_kill-introduce-is_sysrq_oom-helper.patch mm-compaction-add-an-is_via_compact_memory-helper-function.patch mm-vmscan-make-inactive_anon-file_is_low-return-bool.patch mm-memcontrol-make-mem_cgroup_inactive_anon_is_low-return-bool.patch fs-kdev_t-remove-unused-huge_valid_dev-function.patch fs-kdev_t-old-new_valid_dev-can-be-boolean.patch fs-vfs-remove-unnecessary-new_valid_dev-check.patch fs-btrfs-remove-unnecessary-new_valid_dev-check.patch fs-exofs-remove-unnecessary-new_valid_dev-check.patch fs-ext2-remove-unnecessary-new_valid_dev-check.patch fs-ext4-remove-unnecessary-new_valid_dev-check.patch fs-f2fs-remove-unnecessary-new_valid_dev-check.patch fs-hpfs-remove-unnecessary-new_valid_dev-check.patch fs-jfs-remove-unnecessary-new_valid_dev-check.patch fs-ncpfs-remove-unnecessary-new_valid_dev-check.patch fs-nfs-remove-unnecessary-new_valid_dev-check.patch fs-nilfs2-remove-unnecessary-new_valid_dev-check.patch fs-reiserfs-remove-unnecessary-new_valid_dev-check.patch fs-stat-remove-unnecessary-new_valid_dev-check.patch fs-ubifs-remove-unnecessary-new_valid_dev-check.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html