The patch titled Subject: mm/mlock: use offset_in_page macro has been added to the -mm tree. Its filename is mm-mlock-use-offset_in_page-macro.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-mlock-use-offset_in_page-macro.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-mlock-use-offset_in_page-macro.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Alexander Kuleshov <kuleshovmail@xxxxxxxxx> Subject: mm/mlock: use offset_in_page macro linux/mm.h provides offset_in_page() macro. Let's use already predefined macro instead of (addr & ~PAGE_MASK). Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/mlock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN mm/mlock.c~mm-mlock-use-offset_in_page-macro mm/mlock.c --- a/mm/mlock.c~mm-mlock-use-offset_in_page-macro +++ a/mm/mlock.c @@ -560,7 +560,7 @@ static int do_mlock(unsigned long start, struct vm_area_struct * vma, * prev; int error; - VM_BUG_ON(start & ~PAGE_MASK); + VM_BUG_ON(offset_in_page(start)); VM_BUG_ON(len != PAGE_ALIGN(len)); end = start + len; if (end < start) @@ -616,7 +616,7 @@ SYSCALL_DEFINE2(mlock, unsigned long, st lru_add_drain_all(); /* flush pagevec */ - len = PAGE_ALIGN(len + (start & ~PAGE_MASK)); + len = PAGE_ALIGN(len + (offset_in_page(start))); start &= PAGE_MASK; lock_limit = rlimit(RLIMIT_MEMLOCK); @@ -645,7 +645,7 @@ SYSCALL_DEFINE2(munlock, unsigned long, { int ret; - len = PAGE_ALIGN(len + (start & ~PAGE_MASK)); + len = PAGE_ALIGN(len + (offset_in_page(start))); start &= PAGE_MASK; down_write(¤t->mm->mmap_sem); _ Patches currently in -mm which might be from kuleshovmail@xxxxxxxxx are mm-msync-use-offset_in_page-macro.patch mm-nommu-use-offset_in_page-macro.patch mm-mincore-use-offset_in_page-macro.patch mm-early_ioremap-use-offset_in_page-macro.patch mm-percpu-use-offset_in_page-macro.patch mm-util-use-offset_in_page-macro.patch mm-mlock-use-offset_in_page-macro.patch mm-vmalloc-use-offset_in_page-macro.patch mm-mmap-use-offset_in_page-macro.patch mm-mremap-use-offset_in_page-macro.patch lib-halfmd4-use-rol32-inline-function-in-the-round-macro.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html