The patch titled
Subject: MODSIGN: fix a compilation warning in extract-cert
has been added to the -mm tree. Its filename is
modsign-fix-a-compilation-warning-in-extract-cert.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/modsign-fix-a-compilation-warning-in-extract-cert.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/modsign-fix-a-compilation-warning-in-extract-cert.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: David Howells <dhowells@xxxxxxxxxx>
Subject: MODSIGN: fix a compilation warning in extract-cert
Fix the following warning when compiling extract-cert:
scripts/extract-cert.c: In function `write_cert':
scripts/extract-cert.c:89:2: warning: format not a string literal and no fo=
rmat arguments [-Wformat-security]
ERR(!i2d_X509_bio(wb, x509), cert_dst);
^
whereby the ERR() macro is taking cert_dst as the format string. "%s"
should be used as the format string as the path could contain special
characters.
Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
Reported-by: Jim Davis <jim.epost@xxxxxxxxx>
Acked-by : David Woodhouse <david.woodhouse@xxxxxxxxx>
Cc: James Morris <jmorris@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/extract-cert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN scripts/extract-cert.c~modsign-fix-a-compilation-warning-in-extract-cert scripts/extract-cert.c
--- a/scripts/extract-cert.c~modsign-fix-a-compilation-warning-in-extract-cert
+++ a/scripts/extract-cert.c
@@ -86,7 +86,7 @@ static void write_cert(X509 *x509)
ERR(!wb, "%s", cert_dst);
}
X509_NAME_oneline(X509_get_subject_name(x509), buf, sizeof(buf));
- ERR(!i2d_X509_bio(wb, x509), cert_dst);
+ ERR(!i2d_X509_bio(wb, x509), "%s", cert_dst);
if (kbuild_verbose)
fprintf(stderr, "Extracted cert: %s\n", buf);
}
_
Patches currently in -mm which might be from dhowells@xxxxxxxxxx are
modsign-fix-a-compilation-warning-in-extract-cert.patch
mutex-subsystem-synchro-test-module.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
