The patch titled
Subject: zswap: move zswap_pool frequently-used fields together
has been added to the -mm tree. Its filename is
zswap-dynamic-pool-creation-fix-2.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/zswap-dynamic-pool-creation-fix-2.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/zswap-dynamic-pool-creation-fix-2.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Dan Streetman <ddstreet@xxxxxxxx>
Subject: zswap: move zswap_pool frequently-used fields together
Move the "tfm" field in struct zswap_pool to the top, after the "zpool"
field.
As suggested by Sergey Senozhatsky:
>> > ->tfm will be access pretty often, right? did you intentionally put it
>> > at the bottom offset of `struct zswap_pool'?
>>
>> no it wasn't intentional; does moving it up provide a benefit?
>
> well, I just prefer to keep 'read mostly' pointers together. all
> those cache lines, etc.
>
> gcc 5.1, x86_64
>
> struct zswap_pool {
> struct zpool *zpool;
> + struct crypto_comp * __percpu *tfm;
> struct kref kref;
> struct list_head list;
> struct rcu_head rcu_head;
> struct notifier_block notifier;
> char tfm_name[CRYPTO_MAX_ALG_NAME];
> - struct crypto_comp * __percpu *tfm;
> };
>
> ../scripts/bloat-o-meter zswap.o.old zswap.o
> add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-27 (-27)
> function old new delta
> zswap_writeback_entry 659 656 -3
> zswap_frontswap_store 1445 1442 -3
> zswap_frontswap_load 417 414 -3
> zswap_pool_create 438 432 -6
> __zswap_cpu_comp_notifier.part 152 146 -6
> __zswap_cpu_comp_notifier 122 116 -6
Suggested-by: Sergey Senozhatsky <sergey.senozhatsky.work@xxxxxxxxx>
Signed-off-by: Dan Streetman <ddstreet@xxxxxxxx>
Cc: Seth Jennings <sjennings@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/zswap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/zswap.c~zswap-dynamic-pool-creation-fix-2 mm/zswap.c
--- a/mm/zswap.c~zswap-dynamic-pool-creation-fix-2
+++ a/mm/zswap.c
@@ -104,12 +104,12 @@ static struct zpool *zswap_pool;
struct zswap_pool {
struct zpool *zpool;
+ struct crypto_comp * __percpu *tfm;
struct kref kref;
struct list_head list;
struct rcu_head rcu_head;
struct notifier_block notifier;
char tfm_name[CRYPTO_MAX_ALG_NAME];
- struct crypto_comp * __percpu *tfm;
};
/*
_
Patches currently in -mm which might be from ddstreet@xxxxxxxx are
mm-zpool-constify-the-zpool_ops.patch
mm-zbud-constify-the-zbud_ops.patch
zpool-add-zpool_has_pool.patch
zpool-add-zpool_has_pool-fix.patch
zswap-dynamic-pool-creation.patch
zswap-dynamic-pool-creation-fix.patch
zswap-dynamic-pool-creation-fix-2.patch
zswap-change-zpool-compressor-at-runtime.patch
zswap-change-zpool-compressor-at-runtime-fix.patch
zpool-remove-no-op-module-init-exit.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
