The patch titled
Subject: kexec: remove unnecessary test in kimage_alloc_crash_control_pages()
has been added to the -mm tree. Its filename is
kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Minfei Huang <mnfhuang@xxxxxxxxx>
Subject: kexec: remove unnecessary test in kimage_alloc_crash_control_pages()
Transforming PFN(Page Frame Number) to struct page is never failure, so we
can simplify the code logic to do the image->control_page assignment
directly in the loop, and remove the unnecessary conditional judgement.
Signed-off-by: Minfei Huang <mnfhuang@xxxxxxxxx>
Acked-by: Dave Young <dyoung@xxxxxxxxxx>
Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/kexec_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN kernel/kexec.c~kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic kernel/kexec.c
diff -puN kernel/kexec_core.c~kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic kernel/kexec_core.c
--- a/kernel/kexec_core.c~kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic
+++ a/kernel/kexec_core.c
@@ -439,11 +439,10 @@ static struct page *kimage_alloc_crash_c
/* If I don't overlap any segments I have found my hole! */
if (i == image->nr_segments) {
pages = pfn_to_page(hole_start >> PAGE_SHIFT);
+ image->control_page = hole_end;
break;
}
}
- if (pages)
- image->control_page = hole_end;
return pages;
}
_
Patches currently in -mm which might be from mnfhuang@xxxxxxxxx are
kexec-remove-the-unnecessary-conditional-judgement-to-simplify-the-code-logic.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
