The patch titled
Subject: hexdump: do not print debug dumps for !CONFIG_DEBUG
has been added to the -mm tree. Its filename is
hexdump-do-not-print-debug-dumps-for-config_debug.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/hexdump-do-not-print-debug-dumps-for-config_debug.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/hexdump-do-not-print-debug-dumps-for-config_debug.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Linus Walleij <linus.walleij@xxxxxxxxxx>
Subject: hexdump: do not print debug dumps for !CONFIG_DEBUG
print_hex_dump_debug() is likely supposed to be analogous to pr_debug() or
dev_dbg() & friends. Currently it will adhere to dynamic debug, but will
not stub out prints if CONFIG_DEBUG is not set. Let's make it do the
right thing, because I am tired of having my dmesg buffer full of hex
dumps on production systems.
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/printk.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff -puN include/linux/printk.h~hexdump-do-not-print-debug-dumps-for-config_debug include/linux/printk.h
--- a/include/linux/printk.h~hexdump-do-not-print-debug-dumps-for-config_debug
+++ a/include/linux/printk.h
@@ -456,11 +456,17 @@ static inline void print_hex_dump_bytes(
groupsize, buf, len, ascii) \
dynamic_hex_dump(prefix_str, prefix_type, rowsize, \
groupsize, buf, len, ascii)
-#else
+#elif defined(DEBUG)
#define print_hex_dump_debug(prefix_str, prefix_type, rowsize, \
groupsize, buf, len, ascii) \
print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize, \
groupsize, buf, len, ascii)
-#endif /* defined(CONFIG_DYNAMIC_DEBUG) */
+#else
+static inline void print_hex_dump_debug(const char *prefix_str, int prefix_type,
+ int rowsize, int groupsize,
+ const void *buf, size_t len, bool ascii)
+{
+}
+#endif
#endif
_
Patches currently in -mm which might be from linus.walleij@xxxxxxxxxx are
origin.patch
hexdump-do-not-print-debug-dumps-for-config_debug.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
