The patch titled Subject: drivers/crypto/qat: use seq_hex_dump() to dump buffers has been added to the -mm tree. Its filename is crypto-qat-use-seq_hex_dump-to-dump-buffers.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/crypto-qat-use-seq_hex_dump-to-dump-buffers.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/crypto-qat-use-seq_hex_dump-to-dump-buffers.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Subject: drivers/crypto/qat: use seq_hex_dump() to dump buffers Instead of custom approach let's use recently introduced seq_hex_dump() helper. Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Acked-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxx> Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: Joe Perches <joe@xxxxxxxxxxx> Cc: Helge Deller <deller@xxxxxx> Cc: Ingo Tuchscherer <ingo.tuchscherer@xxxxxxxxxx> Cc: Catalin Marinas <catalin.marinas@xxxxxxx> Cc: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/crypto/qat/qat_common/adf_transport_debug.c | 16 +--------- 1 file changed, 2 insertions(+), 14 deletions(-) diff -puN drivers/crypto/qat/qat_common/adf_transport_debug.c~crypto-qat-use-seq_hex_dump-to-dump-buffers drivers/crypto/qat/qat_common/adf_transport_debug.c --- a/drivers/crypto/qat/qat_common/adf_transport_debug.c~crypto-qat-use-seq_hex_dump-to-dump-buffers +++ a/drivers/crypto/qat/qat_common/adf_transport_debug.c @@ -86,9 +86,7 @@ static int adf_ring_show(struct seq_file { struct adf_etr_ring_data *ring = sfile->private; struct adf_etr_bank_data *bank = ring->bank; - uint32_t *msg = v; void __iomem *csr = ring->bank->csr_addr; - int i, x; if (v == SEQ_START_TOKEN) { int head, tail, empty; @@ -113,18 +111,8 @@ static int adf_ring_show(struct seq_file seq_puts(sfile, "----------- Ring data ------------\n"); return 0; } - seq_printf(sfile, "%p:", msg); - x = 0; - i = 0; - for (; i < (ADF_MSG_SIZE_TO_BYTES(ring->msg_size) >> 2); i++) { - seq_printf(sfile, " %08X", *(msg + i)); - if ((ADF_MSG_SIZE_TO_BYTES(ring->msg_size) >> 2) != i + 1 && - (++x == 8)) { - seq_printf(sfile, "\n%p:", msg + i + 1); - x = 0; - } - } - seq_puts(sfile, "\n"); + seq_hex_dump(sfile, "", DUMP_PREFIX_ADDRESS, 32, 4, + v, ADF_MSG_SIZE_TO_BYTES(ring->msg_size), false); return 0; } _ Patches currently in -mm which might be from andriy.shevchenko@xxxxxxxxxxxxxxx are seq_file-provide-an-analogue-of-print_hex_dump.patch crypto-qat-use-seq_hex_dump-to-dump-buffers.patch parisc-use-seq_hex_dump-to-dump-buffers.patch zcrypt-use-seq_hex_dump-to-dump-buffers.patch kmemleak-use-seq_hex_dump-to-dump-buffers.patch wil6210-use-seq_hex_dump-to-dump-buffers.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html