The patch titled
Subject: checkpatch: validate MODULE_LICENSE content
has been added to the -mm tree. Its filename is
checkpatch-validate-module_license-content.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-validate-module_license-content.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-validate-module_license-content.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
Subject: checkpatch: validate MODULE_LICENSE content
There is a well defined list of expected values for MODULE_LICENSE so warn
the user upon usage of unknown values.
Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-validate-module_license-content scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-validate-module_license-content
+++ a/scripts/checkpatch.pl
@@ -5626,6 +5626,24 @@ sub process {
}
}
}
+
+# validate content of MODULE_LICENSE against list from include/linux/module.h
+ if ($line =~ /\bMODULE_LICENSE\s*\(\s*($String)\s*\)/) {
+ my $extracted_string = get_quoted_string($line, $rawline);
+ my $valid_licenses = qr{
+ GPL|
+ GPL\ v2|
+ GPL\ and\ additional\ rights|
+ Dual\ BSD/GPL|
+ Dual\ MIT/GPL|
+ Dual\ MPL/GPL|
+ Proprietary
+ }x;
+ if ($extracted_string !~ /^"(?:$valid_licenses)"$/x) {
+ WARN("MODULE_LICENSE",
+ "unknown module license " . $extracted_string . "\n" . $herecurr);
+ }
+ }
}
# If we have no input at all, then there is nothing to report on
_
Patches currently in -mm which might be from bjorn.andersson@xxxxxxxxxxxxxx are
checkpatch-validate-module_license-content.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
