The patch titled
Subject: compiler-intel: fix wrong compiler barrier() macro
has been added to the -mm tree. Its filename is
compiler-intel-fix-wrong-compiler-barrier-macro.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/compiler-intel-fix-wrong-compiler-barrier-macro.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/compiler-intel-fix-wrong-compiler-barrier-macro.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Subject: compiler-intel: fix wrong compiler barrier() macro
Cleanup commit 73679e508201 ("compiler-intel.h: Remove duplicate
definition") removed the double definition of __memory_barrier()
intrinsics.
However, in doing so, it also removed the preceding #undef barrier by
accident, meaning, the actual barrier() macro from compiler-gcc.h with
inline asm is still in place as __GNUC__ is provided.
Subsequently, barrier() can never be defined as __memory_barrier() from
compiler.h since it already has a definition in place and if we trust the
comment in compiler-intel.h, ecc doesn't support gcc specific asm
statements.
I don't have an ecc at hand (unsure if that's still used in the field?)
and only found this by accident during code review, a revert of that
cleanup would be simplest option.
Fixes: 73679e508201 ("compiler-intel.h: Remove duplicate definition")
Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Reviewed-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
Cc: Pranith Kumar <bobby.prani@xxxxxxxxx>
Cc: H. Peter Anvin <hpa@xxxxxxxxx>
Cc: mancha security <mancha1@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/compiler-intel.h | 2 ++
1 file changed, 2 insertions(+)
diff -puN include/linux/compiler-intel.h~compiler-intel-fix-wrong-compiler-barrier-macro include/linux/compiler-intel.h
--- a/include/linux/compiler-intel.h~compiler-intel-fix-wrong-compiler-barrier-macro
+++ a/include/linux/compiler-intel.h
@@ -13,10 +13,12 @@
/* Intel ECC compiler doesn't support gcc specific asm stmts.
* It uses intrinsics to do the equivalent things.
*/
+#undef barrier
#undef barrier_data
#undef RELOC_HIDE
#undef OPTIMIZER_HIDE_VAR
+#define barrier() __memory_barrier()
#define barrier_data(ptr) barrier()
#define RELOC_HIDE(ptr, off) \
_
Patches currently in -mm which might be from daniel@xxxxxxxxxxxxx are
compiler-intel-fix-wrong-compiler-barrier-macro.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
