The patch titled Subject: fs/affs/symlink.c: remove unneeded err variable has been added to the -mm tree. Its filename is fs-affs-symlinkc-remove-unneeded-err-variable.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/fs-affs-symlinkc-remove-unneeded-err-variable.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/fs-affs-symlinkc-remove-unneeded-err-variable.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Fabian Frederick <fabf@xxxxxxxxx> Subject: fs/affs/symlink.c: remove unneeded err variable err is only assigned to -EIO. Return that value at the end of fail context. Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/affs/symlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -puN fs/affs/symlink.c~fs-affs-symlinkc-remove-unneeded-err-variable fs/affs/symlink.c --- a/fs/affs/symlink.c~fs-affs-symlinkc-remove-unneeded-err-variable +++ a/fs/affs/symlink.c @@ -16,14 +16,12 @@ static int affs_symlink_readpage(struct struct inode *inode = page->mapping->host; char *link = kmap(page); struct slink_front *lf; - int err; int i, j; char c; char lc; pr_debug("follow_link(ino=%lu)\n", inode->i_ino); - err = -EIO; bh = affs_bread(inode->i_sb, inode->i_ino); if (!bh) goto fail; @@ -66,7 +64,7 @@ fail: SetPageError(page); kunmap(page); unlock_page(page); - return err; + return -EIO; } const struct address_space_operations affs_symlink_aops = { _ Patches currently in -mm which might be from fabf@xxxxxxxxx are configfs-unexport-make-static-config_item_init.patch fs-ext4-fsyncc-generic_file_fsync-call-based-on-barrier-flag.patch fs-befs-btreec-remove-unneeded-initializations.patch fs-affs-inodec-remove-unneeded-initialization.patch fs-affs-amigaffsc-remove-unneeded-initialization.patch fs-affs-symlinkc-remove-unneeded-err-variable.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html