The patch titled Subject: metag: use for_each_sg() has been added to the -mm tree. Its filename is metag-use-for_each_sg.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/metag-use-for_each_sg.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/metag-use-for_each_sg.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Akinobu Mita <akinobu.mita@xxxxxxxxx> Subject: metag: use for_each_sg() This replaces the plain loop over the sglist array with for_each_sg() macro which consists of sg_next() function calls. Since metag doesn't select ARCH_HAS_SG_CHAIN, it is not necessary to use for_each_sg() in order to loop over each sg element. But this can help find problems with drivers that do not properly initialize their sg tables when CONFIG_DEBUG_SG is enabled. Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> Cc: James Hogan <james.hogan@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/metag/include/asm/dma-mapping.h | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff -puN arch/metag/include/asm/dma-mapping.h~metag-use-for_each_sg arch/metag/include/asm/dma-mapping.h --- a/arch/metag/include/asm/dma-mapping.h~metag-use-for_each_sg +++ a/arch/metag/include/asm/dma-mapping.h @@ -134,20 +134,24 @@ dma_sync_single_range_for_device(struct } static inline void -dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nelems, +dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sglist, int nelems, enum dma_data_direction direction) { int i; - for (i = 0; i < nelems; i++, sg++) + struct scatterlist *sg; + + for_each_sg(sglist, sg, nelems, i) dma_sync_for_cpu(sg_virt(sg), sg->length, direction); } static inline void -dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, int nelems, - enum dma_data_direction direction) +dma_sync_sg_for_device(struct device *dev, struct scatterlist *sglist, + int nelems, enum dma_data_direction direction) { int i; - for (i = 0; i < nelems; i++, sg++) + struct scatterlist *sg; + + for_each_sg(sglist, sg, nelems, i) dma_sync_for_device(sg_virt(sg), sg->length, direction); } _ Patches currently in -mm which might be from akinobu.mita@xxxxxxxxx are lib-scatterlist-fix-kerneldoc-for-sg_pcopy_tofrom_buffer.patch lib-scatterlist-mark-input-buffer-parameters-as-const.patch linux-next.patch m68k-use-for_each_sg.patch arc-use-for_each_sg.patch metag-use-for_each_sg.patch xtensa-use-for_each_sg.patch mips-use-for_each_sg.patch frv-use-for_each_sg.patch avr32-use-for_each_sg.patch powerpc-use-for_each_sg.patch sparc-use-for_each_sg.patch parisc-use-for_each_sg.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html