The patch titled Subject: printk: improve the description of /dev/kmsg line format has been added to the -mm tree. Its filename is printk-improve-the-description-of-dev-kmsg-line-format.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/printk-improve-the-description-of-dev-kmsg-line-format.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/printk-improve-the-description-of-dev-kmsg-line-format.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Antonio Ospite <ao2@xxxxxx> Subject: printk: improve the description of /dev/kmsg line format The comment about /dev/kmsg does not mention the additional values which may actually be exported, fix that. Also move up the part of the comment instructing the users to ignore these additional values, this way the reading is more fluent and logically compact. Signed-off-by: Antonio Ospite <ao2@xxxxxx> Cc: Joe Perches <joe@xxxxxxxxxxx> Cc: Jonathan Corbet <corbet@xxxxxxx> Cc: Tejun Heo <tj@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/printk/printk.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN kernel/printk/printk.c~printk-improve-the-description-of-dev-kmsg-line-format kernel/printk/printk.c --- a/kernel/printk/printk.c~printk-improve-the-description-of-dev-kmsg-line-format +++ a/kernel/printk/printk.c @@ -195,14 +195,14 @@ static int console_may_schedule; * need to be changed in the future, when the requirements change. * * /dev/kmsg exports the structured data in the following line format: - * "level,sequnum,timestamp;<message text>\n" + * "level,sequnum,timestamp[,additional_values, ... ];<message text>\n" + * + * Users of the export format should ignore possible additional values + * separated by ',', and find the message after the ';' character. * * The optional key/value pairs are attached as continuation lines starting * with a space character and terminated by a newline. All possible * non-prinatable characters are escaped in the "\xff" notation. - * - * Users of the export format should ignore possible additional values - * separated by ',', and find the message after the ';' character. */ enum log_flags { _ Patches currently in -mm which might be from ao2@xxxxxx are linux-next.patch printk-improve-the-description-of-dev-kmsg-line-format.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html