The patch titled Subject: drivers/rtc/rtc-s3c.c: remove one superfluous rtc_valid_tm() check has been added to the -mm tree. Its filename is rtc-rtc-s3c-remove-one-superfluous-rtc_valid_tm-check.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/rtc-rtc-s3c-remove-one-superfluous-rtc_valid_tm-check.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/rtc-rtc-s3c-remove-one-superfluous-rtc_valid_tm-check.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Subject: drivers/rtc/rtc-s3c.c: remove one superfluous rtc_valid_tm() check s3c_rtc_gettime() already returns the result of rtc_valid_tm() on the obtained time so get rid of another call to rtc_valid_tm(). Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/rtc/rtc-s3c.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -puN drivers/rtc/rtc-s3c.c~rtc-rtc-s3c-remove-one-superfluous-rtc_valid_tm-check drivers/rtc/rtc-s3c.c --- a/drivers/rtc/rtc-s3c.c~rtc-rtc-s3c-remove-one-superfluous-rtc_valid_tm-check +++ a/drivers/rtc/rtc-s3c.c @@ -497,9 +497,7 @@ static int s3c_rtc_probe(struct platform device_init_wakeup(&pdev->dev, 1); /* Check RTC Time */ - s3c_rtc_gettime(&pdev->dev, &rtc_tm); - - if (rtc_valid_tm(&rtc_tm)) { + if (s3c_rtc_gettime(&pdev->dev, &rtc_tm)) { rtc_tm.tm_year = 100; rtc_tm.tm_mon = 0; rtc_tm.tm_mday = 1; _ Patches currently in -mm which might be from k.kozlowski@xxxxxxxxxxx are rtc-rtc-ab-b5ze-s3-constify-struct-regmap_config.patch rtc-s5m-add-support-for-s2mps13-rtc.patch rtc-rtc-s3c-fix-failed-first-read-of-rtc-time.patch rtc-rtc-s3c-remove-one-superfluous-rtc_valid_tm-check.patch linux-next.patch rtc-s5m-allow-usage-on-device-type-different-than-main-mfd-type.patch rtc-s5m-allow-usage-on-device-type-different-than-main-mfd-type-v2.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html