+ irq_work-fix-build-failure-when-config_irq_work-not-defined.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: irq_work: fix build failure when CONFIG_IRQ_WORK not defined
has been added to the -mm tree.  Its filename is
     irq_work-fix-build-failure-when-config_irq_work-not-defined.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/irq_work-fix-build-failure-when-config_irq_work-not-defined.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/irq_work-fix-build-failure-when-config_irq_work-not-defined.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Subject: irq_work: fix build failure when CONFIG_IRQ_WORK not defined

When CONFIG_IRQ_WORK is not defined (difficult to do, as it also requires
CONFIG_PRINTK not to be defined), we get a build failure:

kernel/built-in.o: In function `flush_smp_call_function_queue':
kernel/smp.c:263: undefined reference to `irq_work_run'
kernel/smp.c:263: undefined reference to `irq_work_run'
Makefile:933: recipe for target 'vmlinux' failed

Simplest thing to do is to make irq_work_run() a nop when not set.

Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 include/linux/irq_work.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN include/linux/irq_work.h~irq_work-fix-build-failure-when-config_irq_work-not-defined include/linux/irq_work.h
--- a/include/linux/irq_work.h~irq_work-fix-build-failure-when-config_irq_work-not-defined
+++ a/include/linux/irq_work.h
@@ -38,16 +38,17 @@ bool irq_work_queue(struct irq_work *wor
 bool irq_work_queue_on(struct irq_work *work, int cpu);
 #endif
 
-void irq_work_run(void);
 void irq_work_tick(void);
 void irq_work_sync(struct irq_work *work);
 
 #ifdef CONFIG_IRQ_WORK
 #include <asm/irq_work.h>
 
+void irq_work_run(void);
 bool irq_work_needs_cpu(void);
 #else
 static inline bool irq_work_needs_cpu(void) { return false; }
+static inline void irq_work_run(void) { }
 #endif
 
 #endif /* _LINUX_IRQ_WORK_H */
_

Patches currently in -mm which might be from rostedt@xxxxxxxxxxx are

mm-memory-failurec-define-page-types-for-action_result-in-one-place.patch
printk-comment-pr_cont-stating-it-is-only-to-continue-a-line.patch
tracing-remove-use-of-seq_printf-return-value.patch
linux-next.patch
irq_work-fix-build-failure-when-config_irq_work-not-defined.patch

--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux