The patch titled Subject: signal: remove warning about using SI_TKILL in rt_[tg]sigqueueinfo has been added to the -mm tree. Its filename is signal-remove-warning-about-using-si_tkill-in-rt_sigqueueinfo.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/signal-remove-warning-about-using-si_tkill-in-rt_sigqueueinfo.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/signal-remove-warning-about-using-si_tkill-in-rt_sigqueueinfo.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> Subject: signal: remove warning about using SI_TKILL in rt_[tg]sigqueueinfo Sending SI_TKILL from rt_[tg]sigqueueinfo was deprecated, so now we issue a warning on the first attempt of doing it. We use WARN_ON_ONCE, which is not informative and, what is worse, taints the kernel, making the trinity syscall fuzzer complain false-positively from time to time. It does not look like we need this warning at all, because the behaviour changed quite a long time ago (2.6.39), and if an application relies on the old API, it gets EPERM anyway and can issue a warning by itself. So let us zap the warning in kernel. Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx> Cc: Richard Weinberger <richard@xxxxxx> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/signal.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff -puN kernel/signal.c~signal-remove-warning-about-using-si_tkill-in-rt_sigqueueinfo kernel/signal.c --- a/kernel/signal.c~signal-remove-warning-about-using-si_tkill-in-rt_sigqueueinfo +++ a/kernel/signal.c @@ -2992,11 +2992,9 @@ static int do_rt_sigqueueinfo(pid_t pid, * Nor can they impersonate a kill()/tgkill(), which adds source info. */ if ((info->si_code >= 0 || info->si_code == SI_TKILL) && - (task_pid_vnr(current) != pid)) { - /* We used to allow any < 0 si_code */ - WARN_ON_ONCE(info->si_code < 0); + (task_pid_vnr(current) != pid)) return -EPERM; - } + info->si_signo = sig; /* POSIX.1b doesn't mention process groups. */ @@ -3041,12 +3039,10 @@ static int do_rt_tgsigqueueinfo(pid_t tg /* Not even root can pretend to send signals from the kernel. * Nor can they impersonate a kill()/tgkill(), which adds source info. */ - if (((info->si_code >= 0 || info->si_code == SI_TKILL)) && - (task_pid_vnr(current) != pid)) { - /* We used to allow any < 0 si_code */ - WARN_ON_ONCE(info->si_code < 0); + if ((info->si_code >= 0 || info->si_code == SI_TKILL) && + (task_pid_vnr(current) != pid)) return -EPERM; - } + info->si_signo = sig; return do_send_specific(tgid, pid, sig, info); _ Patches currently in -mm which might be from vdavydov@xxxxxxxxxxxxx are mm-page_alloc-call-kernel_map_pages-in-unset_migrateype_isolate.patch mm-hotplug-fix-concurrent-memory-hot-add-deadlock.patch ocfs2-copy-fs-uuid-to-superblock.patch cleancache-zap-uuid-arg-of-cleancache_init_shared_fs.patch cleancache-forbid-overriding-cleancache_ops.patch cleancache-remove-limit-on-the-number-of-cleancache-enabled-filesystems.patch cleancache-remove-limit-on-the-number-of-cleancache-enabled-filesystems-fix.patch memcg-zap-mem_cgroup_lookup.patch memcg-remove-obsolete-comment.patch mm-vmscan-fix-the-page-state-calculation-in-too_many_isolated.patch signal-remove-warning-about-using-si_tkill-in-rt_sigqueueinfo.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html