The patch titled Subject: ocfs2: dereferencing freed pointers in ocfs2_reflink() has been added to the -mm tree. Its filename is ocfs2-dereferencing-freed-pointers-in-ocfs2_reflink.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/ocfs2-dereferencing-freed-pointers-in-ocfs2_reflink.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-dereferencing-freed-pointers-in-ocfs2_reflink.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Subject: ocfs2: dereferencing freed pointers in ocfs2_reflink() The code at the "out" label assumes that "default_acl" and "acl" are NULL, but actually the pointers can be NULL, unitialized, or freed. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Reviewed-by: Mark Fasheh <mfasheh@xxxxxxx> Cc: Joel Becker <jlbec@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/ocfs2/refcounttree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/ocfs2/refcounttree.c~ocfs2-dereferencing-freed-pointers-in-ocfs2_reflink fs/ocfs2/refcounttree.c --- a/fs/ocfs2/refcounttree.c~ocfs2-dereferencing-freed-pointers-in-ocfs2_reflink +++ a/fs/ocfs2/refcounttree.c @@ -4276,7 +4276,7 @@ static int ocfs2_reflink(struct dentry * error = posix_acl_create(dir, &mode, &default_acl, &acl); if (error) { mlog_errno(error); - goto out; + return error; } error = ocfs2_create_inode_in_orphan(dir, mode, _ Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are ocfs2-dereferencing-freed-pointers-in-ocfs2_reflink.patch paride-fix-the-verbose-module-param.patch hfsplus-add-missing-curly-braces-in-hfsplus_delete_cat.patch memstick-mspro_block-add-missing-curly-braces.patch linux-next.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html