The patch titled
Subject: firmware/ihex2fw.c: restore missing default in switch statement
has been added to the -mm tree. Its filename is
ihex-restore-missing-default-in-switch-statement.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/ihex-restore-missing-default-in-switch-statement.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/ihex-restore-missing-default-in-switch-statement.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
Subject: firmware/ihex2fw.c: restore missing default in switch statement
Commit 2473238eac95 ("ihex: add support for CS:IP/EIP records") removes
the "default:" statement in the switch block, making the "return usage();"
line dead code and ihex2fw silently ignoring unknown options. Restore
this statement.
This bug was found by building with HOSTCC=clang and adding
-Wunreachable-code-return to HOSTCFLAGS.
Fixes: 2473238eac95 ("ihex: add support for CS:IP/EIP records")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
firmware/ihex2fw.c | 1 +
1 file changed, 1 insertion(+)
diff -puN firmware/ihex2fw.c~ihex-restore-missing-default-in-switch-statement firmware/ihex2fw.c
--- a/firmware/ihex2fw.c~ihex-restore-missing-default-in-switch-statement
+++ a/firmware/ihex2fw.c
@@ -86,6 +86,7 @@ int main(int argc, char **argv)
case 'j':
include_jump = 1;
break;
+ default:
return usage();
}
}
_
Patches currently in -mm which might be from nicolas.iooss_linux@xxxxxxx are
ihex-restore-missing-default-in-switch-statement.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
