The patch titled
Subject: drivers/rtc/rtc-mc13xxx.c: fix obfuscated and wrong format string
has been added to the -mm tree. Its filename is
rtc-mc13xxx-fix-obfuscated-and-wrong-format-string.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/rtc-mc13xxx-fix-obfuscated-and-wrong-format-string.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/rtc-mc13xxx-fix-obfuscated-and-wrong-format-string.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Subject: drivers/rtc/rtc-mc13xxx.c: fix obfuscated and wrong format string
According to C99, %2.s means 'print two spaces' (a precision of . without
following digits or * means 0). The kernel's printf implementation,
however, treats that case as if no precision was given, but relying on
that quirk is rather silly. Also, since no - (aka left-justify) flag is
given, the field with of 2 would then cause the alarm->enabled case to
come out as "o n". Deobfuscate it.
Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-mc13xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/rtc/rtc-mc13xxx.c~rtc-mc13xxx-fix-obfuscated-and-wrong-format-string drivers/rtc/rtc-mc13xxx.c
--- a/drivers/rtc/rtc-mc13xxx.c~rtc-mc13xxx-fix-obfuscated-and-wrong-format-string
+++ a/drivers/rtc/rtc-mc13xxx.c
@@ -219,7 +219,7 @@ static int mc13xxx_rtc_set_alarm(struct
if (unlikely(ret))
goto out;
- dev_dbg(dev, "%s: o%2.s %lu\n", __func__, alarm->enabled ? "n" : "ff",
+ dev_dbg(dev, "%s: %s %lu\n", __func__, alarm->enabled ? "on" : "off",
s1970);
ret = mc13xxx_rtc_irq_enable_unlocked(dev, alarm->enabled,
_
Patches currently in -mm which might be from linux@xxxxxxxxxxxxxxxxxx are
origin.patch
linux-bitmaph-improve-bitmap_lastfirst_word_mask.patch
rtc-mc13xxx-fix-obfuscated-and-wrong-format-string.patch
lib-lz4-pull-out-constant-tables.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
